throne_tracker: avoid cross fs access #2626

aviraxp · 2025-06-08T07:22:21Z

Files in /data/app may be stacked on incremental fs, if user installs big apps from play store or adb shell. Performing I/O operation on it may results in long-time blocking. As KSU won't get installed in those ways, just avoid cross fs access.

Files in /data/app may be stacked on incremental fs, if user installs big apps from play store or adb shell. Performing I/O operation on it may results in long-time blocking. As KSU won't get installed in those ways, just avoid cross fs access. Signed-off-by: Wang Han <[email protected]>

tiann/KernelSU#2626 why not check magic instead though

upstream's way seems to fail around my_actor, once it tries to resolve path to struct via kern_path. no idea what the issue is, but since we can achieve the same goal, ehh, dont bother with it Replaces: `throne_tracker: avoid cross fs access` tiann/KernelSU#2626 Signed-off-by: backslashxx <[email protected]>

upstream's way seems to fail around my_actor, once it tries to resolve path to struct via kern_path. unsure if UL issue or what. no idea what the issue is, but since we can achieve the same goal, ehh, dont bother with it Replaces: `throne_tracker: avoid cross fs access` tiann/KernelSU#2626 Signed-off-by: backslashxx <[email protected]>

upstream's way seems to fail around my_actor, once it tries to resolve path to struct via kern_path. unsure if UL issue or what. no idea what the issue is, but since we can achieve the same goal, ehh, dont bother with it another option: - maybe just grab /data/app magic then only allow that Replaces: `throne_tracker: avoid cross fs access` tiann/KernelSU#2626 Signed-off-by: backslashxx <[email protected]>

upstream's way seems to fail around my_actor, once it tries to resolve path to struct via kern_path. unsure if UL issue or what. no idea what the issue is, but since we can achieve the same goal, ehh, dont bother with it Replaces: `throne_tracker: avoid cross fs access` tiann/KernelSU#2626 Signed-off-by: backslashxx <[email protected]>

Skip directories in /data/app that are NOT the same as /data/app. This is to avoid scanning incfs and any other stacked filesystems. This is a simple workaround for Ultra-Legacy kernels where upstream's method fails. Replaces: `throne_tracker: avoid cross fs access` tiann/KernelSU#2626 Signed-off-by: backslashxx <[email protected]>

Skip directories that does NOT have the same magic as /data/app. This is to avoid scanning incfs and any other stacked filesystems. This is a workaround for Ultra-Legacy kernels where upstream's method fails. Replaces: `throne_tracker: avoid cross fs access` tiann/KernelSU#2626 Signed-off-by: backslashxx <[email protected]>

Skip directories that does NOT have the same magic as /data/app. This is to avoid scanning incfs and any other stacked filesystems. This is a workaround for Ultra-Legacy kernels where upstream's method fails. Replaces: `throne_tracker: avoid cross fs access` tiann#2626 Signed-off-by: backslashxx <[email protected]>

Skip directories that does NOT have the same magic as /data/app. This is to avoid scanning incfs and any other stacked filesystems. While this is way dumber, it's way cheaper. no kern_path(), no missable path_put(), no ref handling. This is a workaround for Ultra-Legacy kernels where upstream's method fails. Seems doing 50+ kern_path() calls is a bad meme. Replaces: `throne_tracker: avoid cross fs access` tiann#2626 Signed-off-by: backslashxx <[email protected]>

This commit restores compatibility code needed that was removed at tiann/KernelSU@898e9d4 . where upstream dropped all pre-5.10 support Reverts `kernel:Add Huawei hisi check (tiann#1545)` - upstream tiann/KernelSU@4f05fe2 - superceded by `kernel: expose allowlist workaround as Kconfig option` Reverts `throne_tracker: avoid cross fs access (tiann#2626)` - upstream tiann/KernelSU@0b6998b - superceded by `throne_tracker: avoid cross-fs traversal using s_magic check` other changes and cleanups sucompat: ksu_handle_stat(), remove dead ifdef. - just use `ksu_handle_stat(&dfd, &filename->name, &flags);` if you want to hook vfs_statx on 6.1 LINUX_VERSION_CODE / KERNEL_VERSION, ksu.c - reported by Sinclair19 - fix by including version.h fatal_signal_pending, ksud.c - add compat by including sched.h or sched/signal.h conditionally - ref: torvalds/linux@2a1f062 Signed-off-by: backslashxx <[email protected]>

Skip directories that does NOT have the same magic as /data/app. This is to avoid scanning incfs and any other stacked filesystems. While this is way dumber, it's way cheaper. no kern_path(), no missable path_put(), no ref handling. This is a workaround for Ultra-Legacy kernels where upstream's method fails. Seems doing 50+ kern_path() calls is a bad meme. This supercedes `throne_tracker: avoid cross fs access (tiann#2626)` - upstream tiann@0b6998b Signed-off-by: backslashxx <[email protected]>

This commit restores compatibility code needed that was removed at tiann/KernelSU@898e9d4 . where upstream dropped all pre-5.10 support Reverts `kernel:Add Huawei hisi check (tiann#1545)` - upstream tiann/KernelSU@4f05fe2 - superceded by `kernel: expose allowlist workaround as Kconfig option` Reverts `throne_tracker: avoid cross fs access (tiann#2626)` - upstream tiann/KernelSU@0b6998b - superceded by `kernel: throne_tracker: avoid cross-fs traversal using s_magic check` other changes and cleanups sucompat: ksu_handle_stat(), remove dead ifdef. - just use `ksu_handle_stat(&dfd, &filename->name, &flags);` if you want to hook vfs_statx on 6.1 LINUX_VERSION_CODE / KERNEL_VERSION, ksu.c - reported by Sinclair19 - fix by including version.h fatal_signal_pending, ksud.c - add compat by including sched.h or sched/signal.h conditionally - ref: torvalds/linux@2a1f062 Signed-off-by: backslashxx <[email protected]>

Skip directories that does NOT have the same magic as /data/app. This is to avoid scanning incfs and any other stacked filesystems. While this is way dumber, it's way cheaper. no kern_path(), no missable path_put(), no ref handling. This is a workaround for Ultra-Legacy kernels where upstream's method fails. Seems doing 50+ kern_path() calls is a bad meme. This supercedes `throne_tracker: avoid cross fs access (tiann#2626)` - upstream tiann@0b6998b Signed-off-by: backslashxx <[email protected]>