Skip to content

feat(in-app-notifications): add Learn more CTA when supporting text overflows on banner inline notifications #9969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rafaeltonholo merged 2 commits into from
Oct 22, 2025
Merged

feat(in-app-notifications): add Learn more CTA when supporting text overflows on banner inline notifications #9969

rafaeltonholo merged 2 commits into from
Oct 22, 2025

Conversation

@rafaeltonholo
Copy link
Member

@rafaeltonholo rafaeltonholo commented Oct 20, 2025 •
edited
Loading

Resolves #9961.

  • Adds onTextLayout callback to TextBodyMedium
  • Adds the "Learn more" CTA when the supporting text overflows on banner inline notifications
Screen.Recording.2025-10-20.at.9.37.18.AM.mov

@rafaeltonholo rafaeltonholo requested a review from a team as a code owner October 20, 2025 12:40
@rafaeltonholo rafaeltonholo requested a review from wmontwe October 20, 2025 12:40
@rafaeltonholo rafaeltonholo force-pushed the feat/9961/in-app-notifications-show-learn-more-on-text-overflow branch from a5acdc1 to 034bb97 Compare October 21, 2025 13:32
@rafaeltonholo rafaeltonholo force-pushed the feat/9961/in-app-notifications-show-learn-more-on-text-overflow branch from 034bb97 to f9966e1 Compare October 21, 2025 18:32
wmontwe
wmontwe approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeltonholo rafaeltonholo merged commit 9fc0f8d into thunderbird:main Oct 22, 2025
12 checks passed
@rafaeltonholo rafaeltonholo deleted the feat/9961/in-app-notifications-show-learn-more-on-text-overflow branch October 22, 2025 10:54
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 15 milestone Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmontwe wmontwe wmontwe approved these changes

Assignees

@wmontwe wmontwe

Labels

None yet

Projects

None yet

Milestone

Thunderbird 15

Development

Successfully merging this pull request may close these issues.

Add "Learn more" CTA when Banner Inline content text overflow

2 participants

@rafaeltonholo @wmontwe