Skip to content

Conversation

@rafaeltonholo
Copy link
Member

This PR uplifts #9716 to beta, fixing the placeholder account crash issue.

…-when-open-placeholder-folder

fix(drawer): crash when opening placeholder folder
@rafaeltonholo rafaeltonholo requested a review from a team as a code owner October 9, 2025 11:35
@rafaeltonholo rafaeltonholo requested review from asoucar and removed request for a team October 9, 2025 11:35
@thunderbird-botmobile
Copy link
Contributor

thunderbird-botmobile bot commented Oct 9, 2025

Thank you for your uplift request! Please add a comment with the following approval request template filled out.

[Approval Request]
Original Issue/Pull request: #9644/#9716
Regression caused by (issue #):
User impact if declined: The app crashes as soon as the user taps in the placeholder folder.
Testing completed (on daily, etc.): daily, main, beta (local build based on this branch)
Risk to taking this patch (and alternatives if risky): Folder with nested folders could not expand or open in case the account id is null, which is unlikely to happen.

@rafaeltonholo rafaeltonholo changed the title uplift(beta): uplift(beta): fix(drawer): crash when opening placeholder folder Oct 9, 2025
@rafaeltonholo rafaeltonholo changed the title uplift(beta): fix(drawer): crash when opening placeholder folder uplift(beta): crash when opening placeholder folder Oct 9, 2025
@coreycb coreycb merged commit 191cf40 into thunderbird:beta Oct 10, 2025
6 of 8 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 13 milestone Oct 10, 2025
@platform34
Copy link

I see this was lifted to 13.0B5 release. Is it possible to also uplift #9743 "fix: remove Gmail prefix when updating folder list" to beta. It's the secondary part to this fix. The full resolution could then be tested in beta, instead of the partial fix.

@rafaeltonholo rafaeltonholo deleted the uplift/beta/9716/placeholder-account-crash branch October 20, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants