Skip to content

feat(notifications): add in-app notification to message compose #9900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rafaeltonholo merged 2 commits into from
Oct 20, 2025
Merged

feat(notifications): add in-app notification to message compose #9900

rafaeltonholo merged 2 commits into from
Oct 20, 2025

Conversation

@rafaeltonholo
Copy link
Member

@rafaeltonholo rafaeltonholo commented Oct 2, 2025 •
edited
Loading

Resolves #9888.

This PR introduces the following changes:

  • Enable Message Compose to display In-App notifications
  • Improve the in-app banner's animation

@rafaeltonholo rafaeltonholo requested a review from a team as a code owner October 2, 2025 14:21
@rafaeltonholo rafaeltonholo requested a review from asoucar October 2, 2025 14:21
@rafaeltonholo rafaeltonholo force-pushed the feat/9888/add-in-app-notifications-message-composer branch from 917bb5b to a97fe68 Compare October 2, 2025 16:33
asoucar
asoucar requested changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@asoucar asoucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments possibly pending, but wanted to get these available.
I think it is a mistake to have adding the in-app notifications being added to the message compose tied in the PR to fixing the sent folder issue. I think these are two separate ideas that should have separate PRs

@rafaeltonholo rafaeltonholo added the merge block: soft freeze PR to main is blocked: risky code or feature flag enablement must wait until soft freeze lifts. label Oct 3, 2025
@rafaeltonholo
Copy link
Member Author

rafaeltonholo commented Oct 3, 2025

More comments possibly pending, but wanted to get these available. I think it is a mistake to have adding the in-app notifications being added to the message compose tied in the PR to fixing the sent folder issue. I think these are two separate ideas that should have separate PRs

You are right, I will separate the fix from this PR.

@rafaeltonholo rafaeltonholo force-pushed the feat/9888/add-in-app-notifications-message-composer branch 2 times, most recently from 1efecae to e42864a Compare October 3, 2025 13:12
@rafaeltonholo rafaeltonholo mentioned this pull request Oct 3, 2025
Merged
@rafaeltonholo rafaeltonholo requested a review from asoucar October 3, 2025 14:13
@rafaeltonholo rafaeltonholo force-pushed the feat/9888/add-in-app-notifications-message-composer branch from e42864a to 4d3f421 Compare October 10, 2025 12:18
@wmontwe wmontwe removed the merge block: soft freeze PR to main is blocked: risky code or feature flag enablement must wait until soft freeze lifts. label Oct 17, 2025
@rafaeltonholo rafaeltonholo merged commit 3aec86d into thunderbird:main Oct 20, 2025
12 checks passed
@rafaeltonholo rafaeltonholo deleted the feat/9888/add-in-app-notifications-message-composer branch October 20, 2025 10:59
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 15 milestone Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asoucar asoucar asoucar approved these changes

Assignees

@asoucar asoucar

Labels

None yet

Projects

None yet

Milestone

Thunderbird 15

Development

Successfully merging this pull request may close these issues.

In-App Notifications - Add in-app notifications into message composer

3 participants

@rafaeltonholo @asoucar @wmontwe