Migrate DebugLogConfigurator to Use New Logger Infrastructure and Isolate from Timber, While Supporting Timber Setup in Android Module #9863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamim-emon
temporarily deployed
to
botmobile
GitHub Actions
Inactive
shamim-emon
temporarily deployed
to
botmobile
GitHub Actions
Inactive
shamim-emon
force-pushed
the
fix-issue-9573
branch
2 times, most recently
from
d510bed to
bc8b051
Compare
wmontwe
reviewed
Sep 30, 2025
...gging/config/src/androidMain/kotlin/net/thunderbird/core/logging/config/TimberInitializer.kt
Outdated
Show resolved
Hide resolved
shamim-emon
force-pushed
the
fix-issue-9573
branch
7 times, most recently
from
61fc1d4 to
119e639
Compare
wmontwe
reviewed
Oct 2, 2025
...ing/config/src/jvmMain/kotlin/net/thunderbird/core/logging/config/PlatformInitializer.jvm.kt
Outdated
Show resolved
Hide resolved
remove the DebugLogConfigurator from the exclusion list of Timber logging, present in the ValidateLogger#no class should use Timber logging quality test. include the PlatformInitializer.android in the exclusion list of Timber logging, present in the ValidateLogger#no class should use Timber logging quality test.
shamim-emon
force-pushed
the
fix-issue-9573
branch
from
119e639 to
d46c446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Highlights:
DebugLogConfiguratorto the new Logger infrastructure and adds an Android-specific platform configuration, invoked from the common code, to ensure Timber is properly set up.