feat(notifications): add capability to dismiss a notification using NotificationDismisser or NotificationManager #9854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
force-pushed
the
feat/9626/handle-in-app-notification-dismiss
branch
6 times, most recently
from
e77a60f to
4b726d1
Compare
rafaeltonholo
force-pushed
the
feat/9626/handle-in-app-notification-dismiss
branch
2 times, most recently
from
4feef38 to
a4309fc
Compare
wmontwe
previously approved these changes
Oct 2, 2025
Member
wmontwe
left a comment
wmontwe
left a comment
There was a problem hiding this comment.
LGTM
Added a comment for the feature flag, but that could also be a separate task.
...nMain/kotlin/net/thunderbird/feature/notification/impl/receiver/InAppNotificationEventBus.kt
Show resolved
Hide resolved
.../kotlin/net/thunderbird/feature/notification/impl/command/DismissInAppNotificationCommand.kt
Show resolved
Hide resolved
...monMain/kotlin/net/thunderbird/feature/notification/impl/sender/DefaultNotificationSender.kt
Show resolved
Hide resolved
…otificationDismisser or NotificationManager
…hentication issue is solved
rafaeltonholo
force-pushed
the
feat/9626/handle-in-app-notification-dismiss
branch
from
a4309fc to
6a8b9f8
Compare
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9626.
This PR introduces the following changes:
NotificationDismisserorNotificationManager.AuthenticationErrorNotificationnot taking in consideration non-OAuth accounts.