Skip to content

refactor(message-list): introduce AbstractMessageListFragment and migrate all logic from LegacyMessageListFragment to it #10321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rafaeltonholo merged 2 commits into from
Jan 7, 2026
Merged

refactor(message-list): introduce AbstractMessageListFragment and migrate all logic from LegacyMessageListFragment to it #10321

rafaeltonholo merged 2 commits into from
Jan 7, 2026
+131 −61

Conversation

@rafaeltonholo
Copy link
Member

@rafaeltonholo rafaeltonholo commented Jan 6, 2026

Part of #9497.

  • Introduces the AbstractMessageListFragment.
  • Extracts all the logic from MessageListFragment into AbstractMessageListFragment.
  • Introduces the LegacyMessageListFragment, which will utilize the old implementation through AbstractMessageListFragment whenever the enable_message_list_new_state feature is disabled.

Note

The new MessageListFragment will be introduced in a later PR to prevent overwriting the commit history of AbstractMessageListFragment with changes to MessageListFragment.

@rafaeltonholo rafaeltonholo requested a review from a team as a code owner January 6, 2026 14:03
@rafaeltonholo rafaeltonholo requested a review from asoucar January 6, 2026 14:03
@rafaeltonholo rafaeltonholo force-pushed the chore/9497/create-abstract-message-list-fragment branch from cd4fadd to 119c23c Compare January 6, 2026 14:06
@rafaeltonholo rafaeltonholo mentioned this pull request Jan 6, 2026
Merged
@rafaeltonholo
refactor(message-list): rename MessageListFragment to AbstractMessage…
66ba2a3 
…ListFragment
@rafaeltonholo
refactor(message-list): extract LegacyMessageListFragment and introdu…
e37933a 
…ce Factory pattern; allows for future runtime toggling between the legacy fragment and the new `MessageListFragment` using feature flags
@rafaeltonholo rafaeltonholo force-pushed the chore/9497/create-abstract-message-list-fragment branch from 119c23c to e37933a Compare January 7, 2026 14:37
@rafaeltonholo rafaeltonholo mentioned this pull request Jan 7, 2026
Open
@wmontwe wmontwe self-requested a review January 7, 2026 15:43
@wmontwe wmontwe assigned wmontwe and unassigned asoucar Jan 7, 2026
@wmontwe wmontwe removed the request for review from asoucar January 7, 2026 15:43
wmontwe
wmontwe approved these changes Jan 7, 2026
View reviewed changes
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeltonholo rafaeltonholo merged commit 9c935f8 into thunderbird:main Jan 7, 2026
13 checks passed
@rafaeltonholo rafaeltonholo deleted the chore/9497/create-abstract-message-list-fragment branch January 7, 2026 15:47
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 17 milestone Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmontwe wmontwe wmontwe approved these changes

Assignees

@wmontwe wmontwe

Labels

None yet

Projects

None yet

Milestone

Thunderbird 17

Development

Successfully merging this pull request may close these issues.

3 participants

@rafaeltonholo @wmontwe @asoucar