feat(settings): modernize AboutFragment using Jetpack Compose #10310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamim-emon
temporarily deployed
to
botmobile
GitHub Actions
Inactive
shamim-emon
temporarily deployed
to
botmobile
GitHub Actions
Inactive
shamim-emon
changed the title
shamim-emon
force-pushed
the
fix-issue-10309
branch
3 times, most recently
from
608e842 to
7b3a453
Compare
shamim-emon
changed the title
shamim-emon
changed the title
shamim-emon
force-pushed
the
fix-issue-10309
branch
3 times, most recently
from
201f878 to
29b062c
Compare
wmontwe
changed the title
wmontwe
reviewed
Jan 7, 2026
Member
wmontwe
left a comment
wmontwe
left a comment
There was a problem hiding this comment.
Thank you!
I left some comments to use the MainTheme also for spacings and sizes and some small adjustments.
app-common/src/main/kotlin/net/thunderbird/app/common/appVersion/DefaultAppVersionProvider.kt
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/AboutFragment.kt
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/AboutFragment.kt
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/AboutFragment.kt
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/AboutFragment.kt
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/AboutFragment.kt
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/AboutFragment.kt
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/AboutFragment.kt
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/AboutFragment.kt
Outdated
Show resolved
Hide resolved
…iews to ComposeView
…forum related MaterialTextViews to ComposeView
-Introduce AboutContract and enabled MVI. -Move complex logic to AboutViewModel.
shamim-emon
force-pushed
the
fix-issue-10309
branch
from
29b062c to
df92e17
Compare
wmontwe
approved these changes
Jan 8, 2026
shamim-emon
changed the title
wmontwe
changed the title
wmontwe
changed the title
shamim-emon
changed the title
Member
|
@shamim-emon Could you please check why the PR title got changed back? |
shamim-emon
changed the title
Collaborator
Author
@wmontwe Fixed the PR title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the About screen from an XML-based layout to Jetpack Compose, improving readability, testability, and long-term maintainability while aligning with the project’s gradual adoption of Compose.
Implementation Highlights