fix(message-reader): complex html email rendering incorrectly #10076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
added
the
merge block: soft freeze
rafaeltonholo
force-pushed
the
fix/3172/email-html-css-bad-rendering
branch
from
c86d6a8 to
b34acc8
Compare
wmontwe
removed
the
merge block: soft freeze
wmontwe
changed the title
wmontwe
previously approved these changes
Nov 19, 2025
Member
wmontwe
left a comment
wmontwe
left a comment
There was a problem hiding this comment.
Great job! Couldn't spot new issues while browsing my emails and issues seem to be resolved.
app-thunderbird/src/daily/kotlin/net/thunderbird/android/featureflag/TbFeatureFlagFactory.kt
Outdated
Show resolved
Hide resolved
rafaeltonholo
force-pushed
the
fix/3172/email-html-css-bad-rendering
branch
from
b34acc8 to
ad98cb3
Compare
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
force-pushed
the
fix/3172/email-html-css-bad-rendering
branch
from
ad98cb3 to
223801c
Compare
…irectly on DisplayHtml The key changes include: - Moving `HtmlSettings.kt` and `HtmlSettingsProvider.kt` to :core:common. - Introducing `CssClassNameProvider`, `GlobalCssStyleProvider`, `PlainTextMessagePreElementCssStyleProvider`, and `SignatureCssStyleProvider` to dynamically generate CSS for message display. - Updating `DisplayHtml`, `HtmlProcessor`, and their factories to use these new providers. - Refactoring dependency injection to provide the new CSS services. - Using CSS variables for blockquote border colors in `EmailTextToHtml`.
rafaeltonholo
force-pushed
the
fix/3172/email-html-css-bad-rendering
branch
from
223801c to
d3e565f
Compare
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
Contributor
|
very interesting, I will report back once this hits a release and give feedback here |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3172.
This PR will address the majority of emails with complex HTML and CSS being rendered incorrectly. Large images and tables will still zoom out the WebView.
:feature:mail:message:reader:apiand:feature:mail:message:reader:implmodulesDisplayHtmltoCssStyleProviderinterface implementations, enabling old CSS fallback when the feature flag is offFor future improvements: