Experiment - rollkit adapter multiple blocks submission #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
reviewed
Nov 30, 2023
| // but each sugondat-blob is a rollkit-batch that could contain multiple rollkit-blobs | ||
| for batch in block.blobs { | ||
| if batch.namespace == namespace { | ||
| let batch_data: Batch = Decode::decode(&mut &batch.data[..]).unwrap(); |
There was a problem hiding this comment.
This unwrap can be easily triggered by someone submitting another batch manually on the namespace. The assumption that all blobs with the namespace have been submitted through this API is fragile.
Panics should only happen on critical bugs. (IMO unwrap is a major code smell and expect("argument for impossibility") is a much better approach.
There was a problem hiding this comment.
I agree 100% with you! I put this unwrap just because that's a fast iteration to check a possible approach to solve that problem but it was never intended to be pushed on main 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental solution for #62
Not even tested, the goal of this PR is just to discuss about the approach