shim: initial work #32
Conversation
pepyakin
force-pushed
the
pep-shim
branch
2 times, most recently
from
f14a4ca to
ba7ba2c
Compare
this removes all the subxt and substrate cruft from the sovereign adapter.
|
|
||
| #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)] | ||
| pub struct Block { | ||
| // TODO: Hash should be a newtype that serializes to hex. |
There was a problem hiding this comment.
does serde::with work here without a newtype?
There was a problem hiding this comment.
There was a problem hiding this comment.
By default, I was just thinking maybe it's a good idea to have Hash and AccountId instead of [u8; 32] and [u8; 32]. But, yeah, using primitives also an option, it's definitely not a problem right now.
| @@ -0,0 +1,9 @@ | |||
| mod adapters; | |||
There was a problem hiding this comment.
I find the module naming very confusing in this section - adapters are adapter servers and sugondat_rpc are the clients communicating with the underlying node.
can we reorganize a bit? adapter_server and adapter_query or something?
There was a problem hiding this comment.
lots of bikeshedding to do here, but it's in particular around adapters - the sugondat_rpc module is pretty clear.
There was a problem hiding this comment.
Closes #24 #23
This changeset is reviewable on commit-by-commit basis.