-
Notifications
You must be signed in to change notification settings - Fork 10
xtask: migrating from duct to xshell #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
cffa541
to
2951e12
Compare
7207ec0
to
4dbdc69
Compare
4dbdc69
to
c1ca3ac
Compare
76b2104
to
8e8ed0e
Compare
c1ca3ac
to
440a1e0
Compare
8e8ed0e
to
d2ef598
Compare
440a1e0
to
f94b837
Compare
rphmeier
reviewed
Feb 28, 2024
rphmeier
reviewed
Feb 28, 2024
rphmeier
reviewed
Feb 28, 2024
let sov_demo_rollup_path = self.project_path.join("demo/sovereign/demo-rollup/"); | ||
sh.change_dir(sov_demo_rollup_path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this approach looks much more robust
rphmeier
approved these changes
Feb 28, 2024
pepyakin
reviewed
Feb 28, 2024
f94b837
to
4dd0fee
Compare
d2ef598
to
adb8339
Compare
4dd0fee
to
f556561
Compare
xshell does not handle async, so it also requires the addition of Tokio. process group IDs are used to kill all xtask subprocesses
f556561
to
3147dd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duct exhibits too many peculiar behaviors:
duct::Cmd
to astd::process::Command
that is needed to deal with process group IDs.That's why I am moving to
xshell.
However, it does not handle async, so the addition of Tokio is required. Moving everything to Tokio raises all the problems related to issue #228. I handled them using the approach that @pepyakin and I came up with. Zombie processes should not be a problem anymorecloses #228