shim: add ConnectionType #192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Jan 11, 2024
Merged
Closed
gabriele-0201
force-pushed
the
gab_shim_add_no_retry_flag
branch
from
7d360f1 to
16d325a
Compare
rphmeier
reviewed
Jan 12, 2024
| ConnectionType::Single(conn) => { | ||
| action(conn.clone()).await.unwrap_or_else(|e| { | ||
| tracing::error!("{}\n", e); | ||
| // TODO: Is it ok to panic here? |
There was a problem hiding this comment.
no, it's better to adapt the function signatures to support errors.
rphmeier
reviewed
Jan 12, 2024
| // the same connection will be used for all the docks, and thus | ||
| // it's shared among all of them | ||
| #[derive(Clone)] | ||
| pub enum ConnectionType { |
There was a problem hiding this comment.
style: a "type" would likely be a non-data-carrying union
this is just a Connection (which has two different variants)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.