Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Score Distillation via Inversion #508

Merged
merged 15 commits into from
Nov 28, 2024

Conversation

ottogin
Copy link
Contributor

@ottogin ottogin commented Nov 8, 2024

Here is implementation of our paper on analyzing Score Distillation by viewing it as re-parametrization of DDIM, what suggests that the noise sample should be carefully chosen in SDS. In the PR we implement an improved method called SDI where the noise term is regressed via inverting DDIM.

The paper is accepted to NeurIPS 2024.
ArXiv: https://arxiv.org/abs/2405.15891
Webpage: https://lukoianov.com/sdi

The pull request contains implementation of SDI as a module in threestudio and an additional notebook with 2D optimization using different strategies of noise term sampling.

output.png Outdated Show resolved Hide resolved
@thuliu-yt16
Copy link
Collaborator

Appreciate your contribution, nice work! Looks good to me except for some redundant files.

@ottogin
Copy link
Contributor Author

ottogin commented Nov 11, 2024

Good catch, and thank you for reviewing it so fast. Removed the extra files

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have two better ways here to avoid changing the default behavior.

  1. add an option defaulted as False to specify ambient_only in test time
  2. just keep the original behavior if it is not necessary to keep ambient_only during testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I returned it to the default behavior and went with option 1 by adding a new option in the config of the material

Copy link
Collaborator

@thuliu-yt16 thuliu-yt16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@thuliu-yt16 thuliu-yt16 merged commit 915b82d into threestudio-project:main Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants