-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Score Distillation via Inversion #508
Implementation of Score Distillation via Inversion #508
Conversation
docs/Pumpkin_head_zombie_skinny_highly_detailed_photorealistic.gif
Outdated
Show resolved
Hide resolved
Appreciate your contribution, nice work! Looks good to me except for some redundant files. |
Good catch, and thank you for reviewing it so fast. Removed the extra files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have two better ways here to avoid changing the default behavior.
- add an option defaulted as False to specify ambient_only in test time
- just keep the original behavior if it is not necessary to keep ambient_only during testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I returned it to the default behavior and went with option 1 by adding a new option in the config of the material
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Here is implementation of our paper on analyzing Score Distillation by viewing it as re-parametrization of DDIM, what suggests that the noise sample should be carefully chosen in SDS. In the PR we implement an improved method called SDI where the noise term is regressed via inverting DDIM.
The paper is accepted to NeurIPS 2024.
ArXiv: https://arxiv.org/abs/2405.15891
Webpage: https://lukoianov.com/sdi
The pull request contains implementation of SDI as a module in threestudio and an additional notebook with 2D optimization using different strategies of noise term sampling.