forked from doubtfire-lms/doubtfire-api
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stage model to feedback api #27
Open
coskun-kilinc
wants to merge
26
commits into
thoth-tech:new/feedback-enhancement
Choose a base branch
from
coskun-kilinc:new/feedback-enhancement
base: new/feedback-enhancement
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add stage model to feedback api #27
coskun-kilinc
wants to merge
26
commits into
thoth-tech:new/feedback-enhancement
from
coskun-kilinc:new/feedback-enhancement
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stage will be used to sequence a number of feedback rounds when reviewing a particular student submission. This commit adds the ability to post and get stages. Co-authored-by: ugonj <[email protected]> Co-authored-by: wakedreamer <[email protected]>
Added feedback folder loading into application. No module needed in the model. Using a module for the feedback api folder. Co-authored-by: ugonj <[email protected]> Co-authored-by: wakedreamer <[email protected]> Co-authored-by: ublefo <[email protected]>
Starts to capture data necessary for stages in the feedback process Co-authored-by: Andrew Cain <[email protected]> Co-authored-by: ugonj <[email protected]>
…erion_option, feedback_comment, and feedback_comment_template.
Co-authored-by: Andrew Cain <[email protected]>
The code changes add the Stage model to the Feedback API, allowing for the creation and updating of stages.
The code changes add a new table called "stages" to the schema.rb file. This table includes columns for "title", "order", and "task_definition_id".
…hancement New/feedback enhancement
The code changes include the addition of tests for the FeedbackGroup model and updated tests for the FeedbackCommentTemplate model. These tests ensure that a valid feedback group can be created and that invalid feedback groups are handled correctly.
The code changes include the addition of factories and tests for the FeedbackGroup and FeedbackCommentTemplate models. These factories allow for the creation of valid feedback groups and comment templates, and the tests ensure that the models are functioning correctly.
The code changes include the addition of the FeedbackGroup and FeedbackCommentTemplate models, along with their corresponding tests. These models allow for the creation of valid feedback groups and comment templates, and the tests ensure their proper functionality.
This commit updates the feedback feature api endpoints for compatibity with revised models and database schema.
- Modified `feedback_comment_template.rb`, `feedback_group.rb`, and `task_definition.rb` models to align with the new feedback structure. - Removed outdated migrations related to stages and criterion options and introduced new migrations for Feedback Groups and Feedback Comment Templates. - Updated schema to reflect the new feedback group/template structure. - Refactored factories for `FeedbackCommentTemplate` and `FeedbackGroup` to align with the new model relationships. - Deleted obsolete tests and introduced new tests for `FeedbackCommentTemplate` and `FeedbackGroup` to ensure correct functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code changes add the
Stage
model to the Feedback API, allowing for the creation and updating of stages.Fixes # (issue)
Type of change
How Has This Been Tested?
The changes have been tested manually to ensure the new functionality works as expected. The testing process included:
Testing Checklist:
Tests
Checklist: