Change vlan module to set QOS mapping flag #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newer versions of the Linux kernel now check to ensure that QOS mappings also have IFLA_VLAN_QOS_MAPPING set [1]. The kernel will discard QOS atributes where this is not set. The current libnl code for setting vlan attributes uses variable i to set this parameter. This means that only the second QOS map will be applied since i = 1 = IFLA_VLAN_QOS_MAPPING, the rest will be discarded. This patch replaces i in the PUT macro to use the already existing enum value IFLA_VLAN_QOS_MAPPING which equals 1. [1] torvalds/linux@6c21660 Co-authored-by: Daniel Falk [email protected]
thom311
pushed a commit
that referenced
this pull request
Feb 18, 2025
The newer versions of the Linux kernel now check to ensure that QOS mappings also have IFLA_VLAN_QOS_MAPPING set [1]. The kernel will discard QOS atributes where this is not set. The current libnl code for setting vlan attributes uses variable i to set this parameter. This means that only the second QOS map will be applied since i = 1 = IFLA_VLAN_QOS_MAPPING, the rest will be discarded. This patch replaces i in the PUT macro to use the already existing enum value IFLA_VLAN_QOS_MAPPING which equals 1. [1] torvalds/linux@6c21660 Co-authored-by: Daniel Falk [email protected] #421
|
lgtm. Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer versions of the Linux kernel now check to ensure that QOS mappings also have IFLA_VLAN_QOS_MAPPING set [1]. The kernel will discard QOS atributes where this is not set.
The current libnl code for setting vlan attributes uses variable i to set this parameter. This means that only the second QOS map will be applied since i = 1 = IFLA_VLAN_QOS_MAPPING, the rest will be discarded.
This patch replaces i in the PUT macro to use the already existing enum value IFLA_VLAN_QOS_MAPPING which equals 1.
[1] torvalds/linux@6c21660
Co-authored-by: Daniel Falk [email protected]