Fix magic link internal server error

thirdweb-dev · May 24, 2023 · 24475eb · 24475eb
1 parent 0244685
commit 24475eb
Show file tree

Hide file tree

Showing 5 changed files with 99 additions and 267 deletions.
diff --git a/Assets/Thirdweb/Core/Scripts/ThirdwebSDK.cs b/Assets/Thirdweb/Core/Scripts/ThirdwebSDK.cs
@@ -146,7 +146,8 @@ public NativeSession(WalletProvider provider, int lastChainId, string lastRPC, A
                     appName = options.wallet?.appName ?? "Thirdweb Game",
                     appDescription = options.wallet?.appDescription ?? "Thirdweb Game Demo",
                     appIcons = options.wallet?.appIcons ?? new string[] { "https://thirdweb.com/favicon.ico" },
-                    appUrl = options.wallet?.appUrl ?? "https://thirdweb.com"
+                    appUrl = options.wallet?.appUrl ?? "https://thirdweb.com",
+                    magicLinkApiKey = options.wallet?.magicLinkApiKey,
                 };
 
                 FetchChainData();

diff --git a/Assets/Thirdweb/Core/Scripts/Wallet.cs b/Assets/Thirdweb/Core/Scripts/Wallet.cs
@@ -106,6 +106,9 @@ public async Task<string> Connect(WalletConnection walletConnection)
                             await new WaitForSeconds(0.5f);
                         }
 
+                        if (ThirdwebManager.Instance.SDK.nativeSession.options.wallet?.magicLinkApiKey == null)
+                            throw new UnityException("MagicLink API Key is not set!");
+
                         MagicUnity.Instance.Initialize(
                             ThirdwebManager.Instance.SDK.nativeSession.options.wallet?.magicLinkApiKey,
                             new link.magic.unity.sdk.Relayer.CustomNodeConfiguration(oldSession.lastRPC, oldSession.lastChainId)
@@ -528,7 +531,7 @@ public async Task<string> RecoverAddress(string message, string signature)
             {
                 var signer = new EthereumMessageSigner();
                 var addressRecovered = signer.EncodeUTF8AndEcRecover(message, signature);
-                return addressRecovered; // TODO: Check viability
+                return addressRecovered;
             }
         }