-
Notifications
You must be signed in to change notification settings - Fork 543
Version Packages #7164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7164
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update removes several changeset files and updates changelog and package version files for the Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to metadata, changelogs, and version increments. Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (15)
💤 Files with no reviewable changes (7)
🚧 Files skipped from review as they are similar to previous changes (8)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
@@ -1,5 +1,11 @@ | |||
# @thirdweb-dev/insight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog header in this file is incorrect. It currently shows # @thirdweb-dev/insight
but since this is the engine package changelog file, it should be # @thirdweb-dev/engine
to properly identify the package being documented.
# @thirdweb-dev/insight | |
# @thirdweb-dev/engine |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-3
: Add details under the new changelog header
The header## 0.2.85
was added with no associated entries. If there are no user-facing changes beyond the version bump, consider adding a### Patch Changes
section (e.g., “- Version bump to 0.2.85”) for clarity, or defer adding the header until there’s actual changelog content.packages/thirdweb/CHANGELOG.md (1)
7-7
: Fix typo in patch description
There's a misspelling in "colletions". Please correct it to "collections" for clarity:- Handle large NFT colletions when updating metadata + Handle large NFT collections when updating metadata
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
.changeset/breezy-dodos-hunt.md
(0 hunks).changeset/five-sheep-crash.md
(0 hunks).changeset/green-olives-unite.md
(0 hunks)packages/engine/CHANGELOG.md
(1 hunks)packages/engine/package.json
(1 hunks)packages/insight/CHANGELOG.md
(1 hunks)packages/insight/package.json
(1 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(1 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (3)
- .changeset/breezy-dodos-hunt.md
- .changeset/five-sheep-crash.md
- .changeset/green-olives-unite.md
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (11)
packages/wagmi-adapter/package.json (1)
3-3
: Consistent patch version bump
Theversion
field has been correctly updated from0.2.84
to0.2.85
to match the new release. All other metadata and dependency constraints remain unchanged and appropriate.packages/engine/package.json (1)
3-3
: Bump package version to 3.0.2
This version bump aligns with the coordinated patch release for making the client ID optional.packages/insight/package.json (1)
3-3
: Bump package version to 1.0.1
This patch release matches the changeset for optional client ID configuration.packages/thirdweb/package.json (1)
3-3
: Bump package version to 5.101.2
Patch release includes handling large NFT collections and updated dependencies on [email protected] and [email protected].packages/engine/CHANGELOG.md (2)
3-3
: Add changelog entry for version 3.0.2
Changelog now includes the new patch header.
7-7
: Document client ID optional update
Patch entry correctly references PR #7158 and commit ec7bc2b for the client ID optional change.packages/insight/CHANGELOG.md (2)
3-3
: Add changelog entry for version 1.0.1
Changelog header correctly reflects the new patch release.
7-7
: Document client ID optional update
Patch entry references PR #7158 and commit ec7bc2b, matching the intended behavior.packages/thirdweb/CHANGELOG.md (3)
3-4
: Verify version header formatting
The new version bump## 5.101.2
follows the pattern used in earlier releases. No changes needed here.
5-6
: Check changelog section header
The### Patch Changes
header is consistent with previous entries and clearly denotes the type of update.
9-12
: Confirm duplicate commit references
The changelog lists the same SHA (ec7bc2b
) twice for both dependency updates. Please verify that both@thirdweb-dev/[email protected]
and@thirdweb-dev/[email protected]
were released in this single commit. If not, update the second reference or simplify by removing the duplicate link.
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7164 +/- ##
==========================================
+ Coverage 55.67% 55.68% +0.01%
==========================================
Files 904 904
Lines 58392 58392
Branches 4118 4122 +4
==========================================
+ Hits 32510 32516 +6
+ Misses 25776 25770 -6
Partials 106 106
🚀 New features to boost your workflow:
|
80d34db
to
7839b5c
Compare
7839b5c
to
938d9c1
Compare
938d9c1
to
c8bac7d
Compare
d619580
to
0610c37
Compare
0610c37
to
18d6af3
Compare
18d6af3
to
0a65c74
Compare
0a65c74
to
0955239
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
ec7bc2b
Thanks @joaquim-verges! - client id optional@thirdweb-dev/[email protected]
Patch Changes
ec7bc2b
Thanks @joaquim-verges! - client id optional[email protected]
Patch Changes
#7185
41e59a9
Thanks @gregfromstl! - Addscountry
to onramp parameters#7157
52d451f
Thanks @RobbyUitbeijerse! - default the spinner stroke color to currentColor and make the color prop optional#7158
ec7bc2b
Thanks @joaquim-verges! - Handle large NFT colletions when updating metadata#7183
655df03
Thanks @joaquim-verges! - Add ahiddenWallets
prop toConnectEmbed
,ConnectButton
, anduseConnectModal
to hide specific wallets from the connect list.#7191
44a7460
Thanks @gregfromstl! - Remove unnecessary Switch Network button in PayEmbed#7202
3d3c6f3
Thanks @gregfromstl! - Fixes a bug with purchaseData not being included on PayEmbed transfersUpdated dependencies [
ec7bc2b
,ec7bc2b
]:@thirdweb-dev/[email protected]
PR-Codex overview
This PR primarily focuses on updating the version numbers of several packages and includes new changelog entries for those packages, highlighting recent changes and bug fixes.
Detailed summary
.changeset
markdown files.version
inpackage.json
files:thirdweb
: 5.101.1 to 5.101.2@thirdweb-dev/engine
: 3.0.1 to 3.0.2@thirdweb-dev/insight
: 1.0.0 to 1.0.1@thirdweb-dev/wagmi-adapter
: 0.2.84 to 0.2.85@thirdweb-dev/engine
: Added optional client ID.@thirdweb-dev/insight
: Added optional client ID.thirdweb
:country
to onramp parameters.currentColor
.hiddenWallets
prop toConnectEmbed
,ConnectButton
, anduseConnectModal
.PayEmbed
.purchaseData
not included onPayEmbed
transfers.Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Chores