Skip to content

Conversation

@ShvaykaD
Copy link
Contributor

@ShvaykaD ShvaykaD commented Jun 1, 2023

The PR status is set to WIP since there is no release branch for v3.5.2 created in the main repo yet. Also, this change should be applied only after the documentation for custom rule nodes will be updated: https://thingsboard.io/docs/user-guide/contribution/rule-node-development/

Hint for docs regarding the upgrade method:

/**
 * Let's imagine that after a while,
 * you will decide to upgrade the rule node configuration again,
 * for example, from version 1 to version  2.
 * In such a case, our suggestion is to replace the if statement
 * with a switch case model that will include a break statement
 * only before the default case.
 * In such way your upgrade script will be valid
 * even if you will decide to perform upgrade from version 0 to version 2.
 */

@ShvaykaD ShvaykaD added enhancement New feature or request wip Work in progress labels Jun 1, 2023
@ShvaykaD ShvaykaD added this to the 3.5.2 milestone Jun 1, 2023
@ShvaykaD ShvaykaD changed the title updated TbKeyFilterNode to be versioned node && removed destroy method because it is identical to its super method updated TbKeyFilterNode to be versioned node && removed destroy method usages because it is identical to its super method Jun 1, 2023
@smatvienko-tb smatvienko-tb marked this pull request as draft June 10, 2025 11:31
@smatvienko-tb
Copy link
Contributor

@ShvaykaD is this PR still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request wip Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants