config: enable RTC_AEC module for LNL and PTL platforms #9730
Conversation
@lgirdwood sure, but we'd need topologies that include those stub components to load and test them |
|
@tmleman please compile AEC as a LLEXT loadable module, we don't need it in production. EDIT: it may also require changes in testing, a module has to be loaded |
@marcinszkudlinski so it is run-time tested in QB? |
test for AEC + Mock is included in internal CI tests |
tmleman
force-pushed
the
topic/upstream/pr/intel/adsp/ace30/google_rtc
branch
from
9965610 to
4f70175
Compare
tmleman
requested review from
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
@tmleman can you check Internal CI thanks ! |
|
@lgirdwood PR must wait until the required changes in the tests are implemented. Validation is working on it. |
tmleman
force-pushed
the
topic/upstream/pr/intel/adsp/ace30/google_rtc
branch
from
4f70175 to
727d836
Compare
This patch enables the Google Real Time Communication Audio Processing (RTC_AEC) module for the LNL (Lunar Lake) and PTL (Panther Lake) platforms. The RTC_AEC module is essential for performing echo-cancelling and other real-time audio processing tasks. Changes include: - Enabling CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING and CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK in the intel_adsp_ace20_lnl.conf configuration file. - Enabling CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING and CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK in the intel_adsp_ace30_ptl.conf configuration file. This change ensures that the RTC_AEC module is included in the firmware builds for these platforms, allowing for proper testing and functionality of real-time audio processing features. Signed-off-by: Tomasz Leman <[email protected]>
This patch modifies the configuration to change the Google Real Time Communication Audio Processing (RTC_AEC) module from built-in to a loadable module for the MTPM, LNL, and PTL platforms. This change allows for more flexibility in managing the module and reduces the firmware size. Changes include: - Changing CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING from 'y' to 'm' in the intel_adsp_ace15_mtpm.conf configuration file. - Changing CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING from 'y' to 'm' in the intel_adsp_ace20_lnl.conf configuration file. - Changing CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING from 'y' to 'm' in the intel_adsp_ace30_ptl.conf configuration file. - Adding CONFIG_LLEXT, CONFIG_LLEXT_STORAGE_WRITABLE, and CONFIG_MODULES to the intel_adsp_ace30_ptl.conf configuration file to support loadable modules. This change ensures that the RTC_AEC module can be dynamically loaded as needed, providing greater flexibility and potentially improving system performance. Signed-off-by: Tomasz Leman <[email protected]>
tmleman
force-pushed
the
topic/upstream/pr/intel/adsp/ace30/google_rtc
branch
from
727d836 to
8a77adf
Compare
@tmleman I assume we have a valid test implemented now and its being run in CI ? |
This patch removes the CONFIG_LIBRARY_BUILD_LIB option from the MTPM and PTL platform configurations to ensure consistent build behavior across all platforms. The RTC_AEC module was built as an LLEXT module on all platforms, but the library was only present in the LNL platform during CI builds due to the enabled CONFIG_LIBRARY_BUILD_LIB option in MTPM and PTL, which caused discrepancies in the build process. Changes include: - Removing CONFIG_LIBRARY_BUILD_LIB from the intel_adsp_ace15_mtpm.conf configuration file. - Removing CONFIG_LIBRARY_BUILD_LIB from the intel_adsp_ace30_ptl.conf configuration file. This change ensures that the RTC_AEC module library is consistently present across all platforms during CI builds, resolving the issue where the library was only present in the LNL platform. Signed-off-by: Tomasz Leman <[email protected]>
This patch adds the missing include for the Panther Lake (PTL) platform in the rimage configuration file. The absence of this include was causing issues with signing the LLEXT RTC library during CI builds. Changes include: - Adding the include directive for the Panther Lake platform in the tools/rimage/config/platform.toml file. This change ensures that the rimage tool correctly processes the configuration for the Panther Lake platform, resolving the issue with signing the LLEXT RTC library. Signed-off-by: Tomasz Leman <[email protected]>
This patch enables the Google Real Time Communication Audio Processing (RTC_AEC) module for the LNL (Lunar Lake) and PTL (Panther Lake) platforms. The RTC_AEC module is essential for performing echo-cancelling and other real-time audio processing tasks.
Changes include:
This change ensures that the RTC_AEC module is included in the firmware builds for these platforms, allowing for proper testing and functionality of real-time audio processing features.