trace: Use uncached memory in trace_point and panic

It didn't work correctly if multiple cores write to "sw regs" allocated on the same cache line. Signed-off-by: Karol Trzcinski <[email protected]>
thesofproject · Nov 22, 2019 · fcf6c8c · fcf6c8c
1 parent b2f0887
commit fcf6c8c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/include/sof/lib/mailbox.h b/src/include/sof/lib/mailbox.h
@@ -105,9 +105,11 @@ void mailbox_stream_write(size_t offset, const void *src, size_t bytes)
 static inline
 void mailbox_sw_reg_write(size_t offset, uint32_t src)
 {
-	*((volatile uint32_t*)(MAILBOX_SW_REG_BASE + offset)) = src;
-	dcache_writeback_region((void *)(MAILBOX_SW_REG_BASE + offset),
-				sizeof(src));
+	volatile uint32_t *ptr;
+
+	ptr = (volatile uint32_t *)(MAILBOX_SW_REG_BASE + offset);
+	ptr = cache_to_uncache(ptr);
+	*ptr = src;
 }
 
 #endif /* __SOF_LIB_MAILBOX_H__ */