Capture hw mute indicator test code #5310
Draft
+188
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2025 23:34
Add enum for global kcontrol IDs and SOF_IPC4_KCONTROL_GLOBAL_CAPTURE_HW_MUTE in it. Signed-off-by: Jyri Sarha <[email protected]>
…rams Add SOF_IPC4_FW_GLOBAL_KCONTROL_MASK to fw_config_params. The purpose is to inform the driver which global kcontrols are supported by the FW. Signed-off-by: Jyri Sarha <[email protected]>
jsarha
changed the title
ujfalusi
reviewed
Jan 28, 2025
| @@ -119,4 +119,6 @@ void sof_ipc4_update_cpc_from_manifest(struct snd_sof_dev *sdev, | |||
| size_t sof_ipc4_find_debug_slot_offset_by_type(struct snd_sof_dev *sdev, | |||
| u32 slot_type); | |||
|
|
|||
| void snd_ipc4_global_capture_hw_mute_force(struct snd_sof_dev *sdev, bool force); | |||
There was a problem hiding this comment.
I guess the calling of this is under works?
There was a problem hiding this comment.
Any good suggestion of where to follow DSP powerstate is apreciated.
jsarha
force-pushed
the
capture-hw-mute-indicator
branch
3 times, most recently
from
a77b6d4 to
50568cb
Compare
added 2 commits
January 28, 2025 18:51
Implement global kcontrol concept and add capture hw mute indicator implementation in it. Signed-off-by: Jyri Sarha <[email protected]>
…cator This is inteded for driving the mute indicator following dsp power state. If dsp is powerred down the capture muted state should be indicated. Signed-off-by: Jyri Sarha <[email protected]>
jsarha
force-pushed
the
capture-hw-mute-indicator
branch
from
50568cb to
a61cf73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some missing pieces in this code, but I wanted to make it available before I go to short vacation in the end of the week. The missing pieces are:
To test the code, this SOF draft PR can be used: #5310
When integrating the pieces to SOF mic_privacy code, the driver side expects a privacy state update when the DSP has booted up.
There are still unsolved issues to this concept (how to combine SDW/host-linux and DMIC/sof-FW mute status to one indicator) and they need to be resolved, before this work can be finished.