ASoC: SOF: Intel: hda: Create debugfs file to force a clean DSP boot #4738
Conversation
| debugfs_create_bool("request_cold_boot", | ||
| 0644, sdev->debugfs_root, | ||
| &hdev->skip_imr_boot); | ||
| } |
There was a problem hiding this comment.
why not call is 'skip_imr_boot' then? I find 'cold-boot' confusing because we run this code path during reboot aka warm boot...
There was a problem hiding this comment.
we also have a post_fw_run in mtl.c and lnl.c!
There was a problem hiding this comment.
The other name that came up was request_dsp_cold_boot to imply that it is only for the next DSP boot.
I'm fine naming it skip_imr_boot though.
There was a problem hiding this comment.
This option has a slight flaw and would work only to skip IMR boot for the second iteration of FW boot after the value is written isnt it?
There was a problem hiding this comment.
@ranj063, it will skip the IMR boot at the next DSP boot.
If the DSP was off then the next boot will be a 'clean' boot.
If the DSP was not off then it needs to be power cycled.
ujfalusi
force-pushed
the
peter/sof/pr/hda_force_prune_boot_01
branch
from
1757235 to
8e36a19
Compare
|
Changes since v1:
|
When IMR boot is supported on a platform it is always going to be used to boot the DSP unless some catastrophic event happens. There is no way for a developer to force a clean DSP boot without removing and re-inserting the modules. Create a 'skip_imr_boot' debugfs file which can be used to force the next DSP boot as clean (prune) boot. Signed-off-by: Peter Ujfalusi <[email protected]>
When IMR boot is supported on a platform it is always going to be used to boot the DSP unless some catastrophic event happens. There is no way for a developer to force a clean DSP boot without removing and re-inserting the modules.
Create a 'request_cold_boot' debugfs file which can be used to force the next DSP boot as clean (prune) boot.