Board id cleanup for sof_rt5682 #4722
Conversation
brentlu
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao and
ujfalusi
as code owners
Many board configs are duplicated since codec and amplifier type are removed from board quirk. Introduce "jsl_rt5682_def" board to reduce the number of jsl board configs. Signed-off-by: Brent Lu <[email protected]>
Many board configs are duplicated since codec and amplifier type are removed from board quirk. Introduce "tgl_rt5682_def" board to reduce the number of tgl board configs. Signed-off-by: Brent Lu <[email protected]>
Many board configs are duplicated since codec and amplifier type are removed from board quirk. Introduce "adl_rt5682_def" board to reduce the number of adl board configs. Signed-off-by: Brent Lu <[email protected]>
Many board configs are duplicated since codec and amplifier type are removed from board quirk. Introduce "rpl_rt5682_def" board to reduce the number of rpl board configs. Signed-off-by: Brent Lu <[email protected]>
Many board configs are duplicated since codec and amplifier type are removed from board quirk. Introduce "mtl_rt5682_def" board to reduce the number of mtl board configs. Signed-off-by: Brent Lu <[email protected]>
Some dmi quirks are duplicated since codec and amplifier type are removed from board quirk. Remove redundant quirks. Signed-off-by: Brent Lu <[email protected]>
| SOF_RT5682_SSP_CODEC(2) | | ||
| SOF_RT5682_SSP_AMP(0) | | ||
| SOF_RT5682_NUM_HDMIDEV(3) | ||
| ), |
There was a problem hiding this comment.
This one doesn't have SOF_BT_OFFLOAD_SSP(1) and SOF_SSP_BT_OFFLOAD_PRESENT, should we keep it?
There was a problem hiding this comment.
It's weird that BT offload quirk is missing since we try to enable it as long as possible. I'll talk to Mac to see if we could enable it. Removing this entry does no harm anyway, we just have a BE DAI link which does not connect to any FE link.
There was a problem hiding this comment.
As I know it's a wifi module connected via USB so BT offload is not supported. However, I think it's fine to remove this entry since we just add an BE link instead of FE link. There is no change from PCM device point of view.
There was a problem hiding this comment.
As I know it's a wifi module connected via USB so BT offload is not supported. However, I think it's fine to remove this entry since we just add an BE link instead of FE link. There is no change from PCM device point of view.
@brentlu I don't mind we keep the BE. But we need to make sure no BE id will change with or without the BT offload BE. sof_intel_board_set_dai_link() add HDMI-In links after BT offload links. There is no SOF_HDMI_CAPTURE_SSP_MASK in those quirks. So, I think it should be safe to remove this entry.
|
SOFCI TEST |
Many board configs are duplicated since codec and amplifier type are removed from board quirk. Introduce "jsl_rt5682_def", "tgl_rt5682_def", "adl_rt5682_def", "rpl_nau8825_def", and "mtl_rt5682_def" board id to reduce the number of board configs.
Also cleanup redundant DMI quirks for mtl boards.