Quantum#40
Merged
Merged
Conversation
RDF is giving a lot of nan, but at least stuff is running now
…to potential Implemented AT_Sutherland for easy initialisation of AT-corrected Sutherland-potentials.
…r to be correctly implemented now. Cross sections computed for He4-He4, He4-He3, and He3-He3 reproduce those reported by Meeks et al. J. Chem. Phys. (1994), https://doi.org/10.1063/1.466370 This serves as a test that Bosons, Fermions and distinguishable particles are treated correctly.
…um collision integrals. Refactored sanitizing function for mole fractions for clearer naming.
…caching issue where QuantumMie was using density-dependent caches for collision integrals and transfer lengths.
… figures from the paper for the potential curve."
…t integration over energy was cut off too early.
…or numerical solvers).
… be precomputed if possible.)
…e handling of caches in one place.
…dependence bug was fixed.
Collaborator
Author
|
Just pinging @johanslo since reading the top-level description of this PR might be nice to get a quick overview of some new functionality that could turn out to be useful. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains basically all the stuff related to "The limits of the FH corrections"
Short summary:
MolCas VibRotBasic structure:
Quantumclass inherits fromSphericaland implements all our quantum mechanical calculationsset_quantum_active(false), calls will forwarded toSpherical, which does the same old classical calculations.ModTangToennies,Patowski, andHFD_B2) now inherit fromQuantuminstead ofSphericalFH_Correctedinextensions.hpotential_dn, which is then'th derivative of the potential.multiparam.hfor example usage of theFH_Correctedtemplate.multiparam.cppfor examples on how to implement arbitrary order derivatives.extensions.hwe now also have theTabulatedtemplate class, which can be used to quickly create a tabulated version of some other model. For example:Tabulated<Patowski, 1000, 1>, will create a class identical to thePatowskiclass, which uses 1000 tabulated points for the potential and first and second derivative, with first order (1) interpolation between points.Factorials.(h|cpp). I have a more fleshed-out implementation that is more or less completely general (can handle pretty much any analytical function) over in a different repo. That implementation is also ported to Fortran and Python, which is nice.fluids/) have been supplemented withfluids/E_bound/*.datandfluids/E_bound/*.phase_shifts. These are tables of bound-state energies (computed usingMolCas) and phase shifts (computed usingKineticGas). The former is required in order to calculate second virial coefficients. The latter is just nice to have, since these calculations are expensive.Quantumfield in the fluid file, which contains information required for classes inheriting fromQuantum. This includes thehalf_spin(i.e. spin multiplied by two) which determines whether the species is a Boson or a Fermion, and theE_bound(or alternatively,has_E_bound_file: true) which contains the bound state energies in Kelvin.