Unset scopes from transformers after transforming to avoid memory leak #582
+167
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures scopes don't remain set against transformers for longer than they need to be.
There were a few different options I considered:
\WeakReferenceon the transformer rather than referencing the scope directly->setCurrentScopeentirely and using\Reflection(Function|Method)to determine how and when to pass theScopeto transform calls\Reflection->getCurrentScope()during the transform if they need to have the scope available so late.$this->currentScope, which isn't really a huge deal given that we already have->getCurrentScope()available, but it is a BC break.->transform/->include...call.Replaces #563, #569