Repository navigation
backport: v0.27 bitcoin#28503, bitcoin#28037 - #116
Conversation
DCG-Claude
changed the title
bb4f330 to
0946e87
Compare
|
Branch rewritten at
🤖 backportsys, on behalf of the Dash backport pipeline. |
DCG-Claude
changed the title
DCG-Claude
changed the title
83d416a to
2e3108f
Compare
The Cppcheck job ran the fork's develop workflow, which calls test/lint/cppcheck-dash.py. Develop renamed it to that in d9e487e (dashpay#7966); this branch's base still has test/lint/lint-cppcheck-dash.py, so the job exited 127 with 'No such file or directory'. The macOS depends failure (gmp configure could not find a working compiler) is in depends/ci, which this branch does not touch; develop has also renamed the macOS CI setup script since the base, so it is probably the same mismatch and should clear after a rebase onto develop. This branch is based on 🤖 backportsys, on behalf of the Dash backport pipeline. |
This check fails only because the pull request has no milestone set. That is PR metadata a maintainer has to add, not anything in these backport commits. 🤖 backportsys, on behalf of the Dash backport pipeline. |
…, use SER_PARAMS_OPFUNC 9999019 Remove WithParams serialization helper (MarcoFalke) ffffb4a scripted-diff: Use ser params operator (MarcoFalke) fae9054 test: Use SER_PARAMS_OPFUNC in serialize_tests.cpp (MarcoFalke) Pull request description: Every serialization parameter struct already has the `SER_PARAMS_OPFUNC`, except for one in the tests. For consistency, and to remove verbose code, convert the test to `SER_PARAMS_OPFUNC`, and use it everywhere, then remove the `WithParams` helper. ACKs for top commit: ajtowns: reACK 9999019 TheCharlatan: Re-ACK 9999019 Tree-SHA512: be9cae4225a502486fe8d552aaf4b2cd2904a9f73cce9d931c6b7c757594ff1982fcc2c30d00d012cd12b0a9531fd609f8bcd7c94b811e965ac087eb8a3589d3 Dash adaptations: - src/test/serialize_tests.cpp: upstream's BaseFormat struct and RAW/HEX constants follow Dash-only UnserializeVectorWithMaxSize/LimitedVectorFormatter tests, which are kept - src/evo/deterministicmns.h: Dash-only GetUniquePropertyHash() now uses ser_params(v) instead of the removed WithParams(ser_params, v)
f1684bb rpc: mention that migratewallet can take a while (Andrew Chow) 9ecff99 rpc: Drop migratewallet experimental warning (Andrew Chow) Pull request description: The migration process itself hasn't fundamentally changed since it was added, so I think it's reasonable to say that it is no longer experimental. ACKs for top commit: maflcko: lgtm ACK f1684bb josibake: ACK bitcoin@f1684bb furszy: ACK bitcoin@f1684bb ryanofsky: Code review ACK f1684bb willcl-ark: ACK f1684bb Tree-SHA512: 99b176cddbf3878c76bd4c80c030106200bf03139785e26dbae3341e1a675b623a13cd6dc7a0bb78344335bf859ae7548d97b2b58eb650c6e7b305d7cdc86e40
DCG-Claude
changed the title
2e3108f to
12d05b6
Compare
This job fails because the pull request has no milestone set (MILESTONE is empty in the log); it doesn't build or test anything. Neither backport (bitcoin#28503, bitcoin#28037) can cause or fix it. A maintainer needs to set a milestone on the pull request, and then the check will pass. 🤖 backportsys, on behalf of the Dash backport pipeline. |
This job only checks that the pull request has a milestone, and the log shows MILESTONE was empty. It doesn't depend on any code in the bitcoin#28503 or bitcoin#28037 backports, so the branch needs no change. Setting a milestone on the PR should make it pass. 🤖 backportsys, on behalf of the Dash backport pipeline. |
This job failed because the 'Require a milestone' check found no milestone set on the pull request (MILESTONE is empty). It checks PR metadata, not code, and neither bitcoin#28503 nor bitcoin#28037 touches it. A maintainer needs to set a milestone on the PR, and then the check should pass. 🤖 backportsys, on behalf of the Dash backport pipeline. |
|
merged as dashpay#8006 |
Automated Bitcoin Core v0.27 backports, batch
backport-0.27-b004-src-test.af77fd9ff312d05b6864Provenance
Each commit passed: cherry-pick (adapted by an Opus lane only where conflicts existed), build, touched tests, a mechanical diff-of-diffs check (every upstream hunk landed; no added line without an upstream counterpart), and an independent Opus verification lane where anything was adapted. Gate rows and lane artifacts are in the backportsys DB.