feat(wip): Do not allow template flows to be deleted / archived #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (1)
|
DafyddLlyr
changed the title
DafyddLlyr
changed the title
DafyddLlyr
force-pushed
the
dp/template-flows-delete-permissions
branch
4 times, most recently
from
d74ce13 to
9de2b6f
Compare
DafyddLlyr
commented
Feb 5, 2025
Comment on lines
+652
to
+675
| filter: | ||
| deleted_at: | ||
| _is_null: true |
There was a problem hiding this comment.
This repeated pattern means that archived flows cannot be selected.
DafyddLlyr
commented
Feb 5, 2025
hasura.planx.uk/metadata/tables.yaml
Outdated
Comment on lines
822
to
828
| check: | ||
| _and: | ||
| - deleted_at: | ||
| _is_null: false | ||
| - templated_flows: | ||
| id: | ||
| _is_null: false |
There was a problem hiding this comment.
This repeated pattern is a post-update check which ensures that flows cannot be archived if they have associated templated flows derived from them.
DafyddLlyr
force-pushed
the
dp/template-flows-delete-permissions
branch
5 times, most recently
from
9532b5b to
db405ff
Compare
DafyddLlyr
force-pushed
the
dp/template-flows-delete-permissions
branch
from
db405ff to
b457494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
flows.deleted_atcolumn in order to allow a soft delete patternPermissions
flowstableflows.deleted_atcolumn (within the parameters of their current permission levels)flows.deleted_at) for template flowsSome of this is pretty tricky to understand via the
tables.yamland took a bit of trial and error to figure out. Some e2e test coverage is needed here to explain this and act as a guard rail for future changes. I'm planning on introducing this in a future PR so that I'm not holding up the "archive flows" ticket @RODO94 will be shortly working on.