feat: verify email before downloading application

api.planx.uk/modules/send/downloadApplicationFiles/index.ts

@@ -20,7 +20,8 @@ export async function downloadApplicationFiles(
     const { teamSettings } = await getTeamEmailSettings(
       req.query.localAuthority as string,
     );
-    if (teamSettings.submissionEmail !== req.query.email) {
+    const decodedEmail = decodeURIComponent(req.query.email as string);
+    if (teamSettings.submissionEmail !== decodedEmail) {
       return next({
         status: 403,
         message:

api.planx.uk/modules/send/email/index.ts

@@ -35,20 +35,15 @@ export const sendToEmail: SendIntegrationController = async (
     const { email, flow } = await getSessionEmailDetailsById(sessionId);
     const flowName = flow.name;
 
-    // Make application files download magic link
-    const params = new URLSearchParams({
-      email: teamSettings.submissionEmail,
-      localAuthority: localAuthority,
-    });
-    const applicationFilesDownloadLink = `${process.env.API_URL_EXT}/download-application-files/${sessionId}?${params}`;
+    const serviceURL = `${process.env.EDITOR_URL_EXT}/${localAuthority}/${flow.slug}/${sessionId}`;
 
     // Prepare email template
     const config: EmailSubmissionNotifyConfig = {
       personalisation: {
         serviceName: flowName,
         sessionId,
         applicantEmail: email,
-        downloadLink: applicationFilesDownloadLink,
+        downloadLink: `${serviceURL}/download-application`, // send to verifySubmissionEmail page
         ...teamSettings,
       },
     };

api.planx.uk/modules/send/email/service.ts

@@ -1,9 +1,9 @@
-import { gql } from "graphql-request";
-import { $api } from "../../../client/index.js";
 import type {
   Session,
   TeamContactSettings,
 } from "@opensystemslab/planx-core/types";
+import { gql } from "graphql-request";
+import { $api } from "../../../client/index.js";
 import type { EmailSubmissionNotifyConfig } from "../../../types.js";
 
 interface GetTeamEmailSettings {

editor.planx.uk/package.json

@@ -153,6 +153,7 @@
     "jest-environment-jsdom": "^29.7.0",
     "jest-localstorage-mock": "^2.4.26",
     "lint-staged": "^13.2.3",
+    "msw": "^2.7.0",
     "postcss": "^8.4.32",
     "prettier": "^3.0.0",
     "react-refresh": "^0.14.0",