Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: npm publish main if package version changes #30

Closed
wants to merge 2 commits into from

Conversation

johnrees
Copy link
Contributor

Currently set to dry-run for testing. I'm not sure if it'll like pnpm yet. GitHub is being weird too so I'll try this out tomorrow.

In theory we can keep merging to main as we are, then when we want to create a release, we create a PR that bumps the package version number (and any CHANGELOG updates) and it'll then auto publish on merge.

@netlify
Copy link

netlify bot commented Aug 10, 2021

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit 87269ad
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/6241f03b4d6ebd000888299e
😎 Deploy Preview https://deploy-preview-30--oslmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@johnrees
Copy link
Contributor Author

netlify failed because github was dead at the time

@jessicamcinchak
Copy link
Member

cool!! this seems like a great simple solution

i queued up some changes to try it out!! :#36 (but let's merge #34 first 🙂)

@johnrees johnrees force-pushed the jr/auto-publish-npm branch from 1b3ceb0 to 7d47004 Compare March 28, 2022 17:17
@johnrees
Copy link
Contributor Author

closing in favour of #135 but happy to pursue this route instead if you think it's better @jessicamcinchak

@johnrees johnrees closed this Mar 28, 2022
@jessicamcinchak jessicamcinchak deleted the jr/auto-publish-npm branch August 5, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants