Skip to content

Bulk operations skip permission checks #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adelowo merged 3 commits into from
Mar 18, 2026
Merged

Bulk operations skip permission checks #464

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3b1183
when deleting/editing bulk items, auth/permissions are skipped
adelowo Mar 18, 2026
4f72b60
keep log as it is more contextual that auth was skipped
adelowo Mar 18, 2026
10808ce
use Batch
adelowo Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 61 additions & 44 deletions entfga/templates/authzChecks.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ func newOrganizationContextKey(e string) *map[string]any {

{{ if $n.Annotations.EntGQL | hasMutationInputSet }}
func (m *{{ $mutator }}) CheckAccessForEdit(ctx context.Context) error {
var objectID string
var ids []string

{{ if $orgOwned }}
caller, ok := auth.CallerFromContext(ctx)
Expand Down Expand Up @@ -155,7 +155,9 @@ func newOrganizationContextKey(e string) *map[string]any {
}
}

objectID = orgID
if orgID != "" {
ids = append(ids, orgID)
}
{{ else }}

gCtx := graphql.GetFieldContext(ctx)
Expand All @@ -173,22 +175,26 @@ func newOrganizationContextKey(e string) *map[string]any {
input, ok := gInput.(Create{{ $name }}Input)
if ok {
{{- if $nillable }}
objectID = *input.{{ $idField }}
ids = append(ids, *input.{{ $idField }})
{{ else }}
objectID = input.{{ $idField }}
ids = append(ids, input.{{ $idField }})
{{ end }}
}
{{- end }}

// check the id from the args
if objectID == "" {
objectID, _ = gCtx.Args["{{ $idField | ToLower }}"].(string)
if len(ids) == 0 {
if id, ok := gCtx.Args["{{ $idField | ToLower }}"].(string); ok {
ids = append(ids, id)
} else if bulkIDs, ok := gCtx.Args["ids"].([]string); ok {
ids = bulkIDs
}
}

{{- if ne $idField "ID" }}
// if this is still empty, we need to query the object to get the object id
// this happens on join tables where we have the join ID (for updates and deletes)
if objectID == "" {
if len(ids) == 0 {
id, ok := gCtx.Args["id"].(string)
if ok {
// allow this query to run
Expand All @@ -197,15 +203,15 @@ func newOrganizationContextKey(e string) *map[string]any {
if err != nil {
return privacy.Skipf("nil request, skipping auth check")
}
objectID = ob.{{ $idField }}
ids = append(ids, ob.{{ $idField }})
}
}
{{- end }}
{{- end }}

// request is for a list objects, will get filtered in interceptors
if objectID == "" {
return privacy.Allowf("nil request, bypassing auth check")
if len(ids) == 0 {
return privacy.Skipf("nil request, bypassing auth check")
}

caller, ok := auth.CallerFromContext(ctx)
Expand All @@ -214,26 +220,28 @@ func newOrganizationContextKey(e string) *map[string]any {
return privacy.Skipf("unable to get caller from context")
}

ac := fgax.AccessCheck{
Relation: fgax.CanEdit,
ObjectType: "{{ $objectType | ToLower }}",
ObjectID: objectID,
SubjectType: caller.SubjectType(),
SubjectID: caller.SubjectID,
Context: newOrganizationContextKey(caller.SubjectEmail),
checks := make([]fgax.AccessCheck, 0, len(ids))
for _, objectID := range ids {
checks = append(checks, fgax.AccessCheck{
Relation: fgax.CanEdit,
ObjectType: "{{ $objectType | ToLower }}",
ObjectID: objectID,
SubjectType: caller.SubjectType(),
SubjectID: caller.SubjectID,
Context: newOrganizationContextKey(caller.SubjectEmail),
})
}

log.Debug().Interface("access_check", ac).Msg("checking relationship tuples")
log.Debug().Interface("access_checks", checks).Msg("batch checking relationship tuples")

access, err := m.Authz.CheckAccess(ctx, ac)
if err == nil && access {
return privacy.Allow
}
allowedIDs, err := m.Authz.BatchCheckObjectAccess(ctx, checks)
if err != nil || len(allowedIDs) != len(ids) {
log.Error().Err(err).Int("allowed", len(allowedIDs)).Int("requested", len(ids)).Msg("access denied")

log.Error().Interface("access_check", ac).Bool("access_result", access).Msg("access denied")
return ErrPermissionDenied
}

// return error if the action is not allowed
return ErrPermissionDenied
return privacy.Allow
}

func (m *{{ $mutator }}) CheckAccessForDelete(ctx context.Context) error {
Expand All @@ -244,11 +252,18 @@ func newOrganizationContextKey(e string) *map[string]any {
return privacy.Skipf("not a graphql request, no context to check")
}

objectID, ok := gCtx.Args["id"].(string)
if !ok {
var ids []string

if id, ok := gCtx.Args["id"].(string); ok {
ids = append(ids, id)
} else if bulkIDs, ok := gCtx.Args["ids"].([]string); ok {
ids = bulkIDs
}

if len(ids) == 0 {
log.Info().Msg("no id found in args, skipping auth check, will be filtered in hooks")

return privacy.Allowf("nil request, bypassing auth check")
return privacy.Skipf("nil request, bypassing auth check")
}

caller, ok := auth.CallerFromContext(ctx)
Expand All @@ -257,27 +272,29 @@ func newOrganizationContextKey(e string) *map[string]any {
return privacy.Skipf("unable to get caller from context")
}

ac := fgax.AccessCheck{
Relation: fgax.CanDelete,
ObjectType: "{{ $objectType | ToLower }}",
ObjectID: objectID,
SubjectType: caller.SubjectType(),
SubjectID: caller.SubjectID,
Context: newOrganizationContextKey(caller.SubjectEmail),
checks := make([]fgax.AccessCheck, 0, len(ids))
for _, objectID := range ids {
checks = append(checks, fgax.AccessCheck{
Relation: fgax.CanDelete,
ObjectType: "{{ $objectType | ToLower }}",
ObjectID: objectID,
SubjectType: caller.SubjectType(),
SubjectID: caller.SubjectID,
Context: newOrganizationContextKey(caller.SubjectEmail),
})
}

log.Debug().Interface("access_check", ac).Msg("checking relationship tuples")
log.Debug().Interface("access_checks", checks).Msg("batch checking relationship tuples")

access, err := m.Authz.CheckAccess(ctx, ac)
if err == nil && access {
return privacy.Allow
}
allowedIDs, err := m.Authz.BatchCheckObjectAccess(ctx, checks)
if err != nil || len(allowedIDs) != len(ids) {
log.Error().Err(err).Int("allowed", len(allowedIDs)).Int("requested", len(ids)).Msg("access denied")

log.Error().Interface("access_check", ac).Bool("access_result", access).Msg("access denied")
return ErrPermissionDenied
}

// return error if the action is not allowed
return ErrPermissionDenied
return privacy.Allow
}
{{- end }}
{{- end }}
{{- end }}
{{- end }}
Loading