Open
Conversation
MuriloLopes477
force-pushed
the
update-existing-schema-queries
branch
from
a80f549 to
6909b2b
Compare
Member
golanglemonade
left a comment
golanglemonade
left a comment
There was a problem hiding this comment.
this looks good! All my comments are really around readability of code + go best practices.
Did you try adding a field to the schema in the vanilla/_example and ensure it gets added here?
Co-authored-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com> Signed-off-by: Murilo Ferreira Lopes <97425413+MuriloLopes477@users.noreply.github.com>
Co-authored-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com> Signed-off-by: Murilo Ferreira Lopes <97425413+MuriloLopes477@users.noreply.github.com>
Co-authored-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com> Signed-off-by: Murilo Ferreira Lopes <97425413+MuriloLopes477@users.noreply.github.com>
Co-authored-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com> Signed-off-by: Murilo Ferreira Lopes <97425413+MuriloLopes477@users.noreply.github.com>
Co-authored-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com> Signed-off-by: Murilo Ferreira Lopes <97425413+MuriloLopes477@users.noreply.github.com>
Co-authored-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com> Signed-off-by: Murilo Ferreira Lopes <97425413+MuriloLopes477@users.noreply.github.com>
Co-authored-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com> Signed-off-by: Murilo Ferreira Lopes <97425413+MuriloLopes477@users.noreply.github.com>
Co-authored-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com> Signed-off-by: Murilo Ferreira Lopes <97425413+MuriloLopes477@users.noreply.github.com>
Signed-off-by: Murilo Ferreira Lopes <97425413+MuriloLopes477@users.noreply.github.com>
Signed-off-by: Murilo Ferreira Lopes <97425413+MuriloLopes477@users.noreply.github.com>
Refactor updateQuery function to improve error handling and comments. Signed-off-by: Murilo Ferreira Lopes <97425413+MuriloLopes477@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.