-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unrecognized Gaussian input format: *.com and *.gjf #376
Conversation
Reviewer's Guide by SourceryThe PR fixes a bug in file format recognition for Gaussian input files by modifying how file extensions are mapped to their corresponding format modules. Instead of using the module name as the key, it now uses the file extensions defined in the module's PATTERNS attribute. Class diagram for format module mapping updateclassDiagram
class FormatModule {
+PATTERNS: List<String>
}
class FormatMapper {
+_find_format_modules(): Map<String, FormatModule>
}
FormatMapper --> FormatModule: uses PATTERNS for mapping
note for FormatMapper "Now uses file extensions from PATTERNS instead of module names for mapping."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @FanwangM - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a typo in the code: 'replate' should be 'replace'
- The implementation needs to handle potential conflicts when multiple format modules support the same file extension pattern
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me but I'd like an opinion from someone who does a lot more work with IOData.
I figured out the right way to use the database, and this should not be seen as a bug. So I am closing it here. |
The current implementation does not support .com and *gjf because it used module name instead of "PATTERNS".
Summary by Sourcery
Bug Fixes: