Skip to content

chore: Bump xunit.v3 from 3.2.2 to 4.0.0 - #250

Merged
goloroden merged 3 commits into
mainfrom
dependabot/nuget/src/EventSourcingDb.Tests/xunit.v3-4.0.0
Sep 5, 2026
Merged

chore: Bump xunit.v3 from 3.2.2 to 4.0.0#250
goloroden merged 3 commits into
mainfrom
dependabot/nuget/src/EventSourcingDb.Tests/xunit.v3-4.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Updated xunit.v3 from 3.2.2 to 4.0.0.

Release notes

Sourced from xunit.v3's releases.

No release notes found for this version range.

Commits viewable in compare view.

@dependabot
dependabot Bot requested a review from a team as a code owner August 27, 2026 19:56
@dependabot
dependabot Bot force-pushed the dependabot/nuget/src/EventSourcingDb.Tests/xunit.v3-4.0.0 branch from 4655fcf to a20dbbe Compare September 3, 2026 20:12
@goloroden

goloroden commented Sep 3, 2026

Copy link
Copy Markdown
Member

@dependabot recreate

@dependabot
chore: Bump xunit.v3 from 3.2.2 to 4.0.0
060a8c5 
---
updated-dependencies:
- dependency-name: xunit.v3
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/nuget/src/EventSourcingDb.Tests/xunit.v3-4.0.0 branch from a20dbbe to 060a8c5 Compare September 3, 2026 20:19
@goloroden

goloroden commented Sep 4, 2026

Copy link
Copy Markdown
Member

Leaving this open: the bump itself resolves, but the test run no longer starts.

Microsoft.Testing.Platform.MSBuild.targets(320,5): error : Testing with VSTest
target is no longer supported by Microsoft.Testing.Platform on .NET 10 SDK and
later. If you use dotnet test, you should opt-in to the new dotnet test experience.

Moving xunit.v3 to 4.0.0 pulls in a Microsoft.Testing.Platform that drops the VSTest
target on the .NET 10 SDK. Getting this in means opting the test project into the new
dotnet test experience — a change to how tests are executed, which wants to be
reviewed on its own rather than ridden in on a dependency bump.

@goloroden

goloroden commented Sep 5, 2026

Copy link
Copy Markdown
Member

Not merging this yet: the QA job fails before it gets to this change.

The .NET 10 SDK no longer runs tests through the VSTest target:

Microsoft.Testing.Platform.MSBuild.targets(320,5): error : Testing with VSTest
target is no longer supported by Microsoft.Testing.Platform on .NET 10 SDK and
later. If you use dotnet test, you should opt-in to the new dotnet test
experience.

This is not caused by the packages in this pull request — every run in this
repository fails the same way, on every target framework, because the SDK on the
runner is 10.0.400. Fixing it means opting the test projects into the new
dotnet test experience (Microsoft.Testing.Platform), which is a change to the
test setup rather than dependency maintenance.

Leaving this open until that lands.

goloroden and others added 2 commits September 5, 2026 22:24
@goloroden
Merge branch 'main' of github.com:thenativeweb/eventsourcingdb-client…
8e0f8c8 
…-dotnet into dependabot/nuget/src/EventSourcingDb.Tests/xunit.v3-4.0.0
@goloroden @claude
fix: Move the tests onto Microsoft.Testing.Platform.
6dbf8fa 
The .NET 10 SDK refuses to run tests through the VSTest target, so every job in
this repository failed before it reached the xunit.v3 bump:

    Testing with VSTest target is no longer supported by Microsoft.Testing.
    Platform on .NET 10 SDK and later.

Four changes, each one needed:

- `global.json` selects the runner. The property name in the failing target,
  `_SupportsGlobalJsonTestRunner`, is what points at global.json rather than
  dotnet.config; neither a csproj property nor dotnet.config has any effect.
- `<OutputType>Exe</OutputType>`, because xunit.v3 4.0 requires test projects to
  be executable — under Microsoft.Testing.Platform a test project is a program,
  not a library a host loads.
- Microsoft.NET.Test.Sdk, xunit.runner.visualstudio and coverlet.collector are
  removed. All three exist to serve VSTest; xunit.v3 carries its own platform
  integration. Nothing asked coverlet for coverage — `make test` never passed a
  collector.
- `dotnet test` takes `--project` now; the positional form is rejected.

Verified locally with `make qa` on .NET 9 and .NET 10: 126 tests, none failing.
net8.0 could not be run here because that runtime is not installed on this
machine; CI installs 8.0.x explicitly.

Worth a look separately: the QA matrix lists three SDK versions but every job
installs all three and runs the same `make qa`, so the three runs are identical.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X8dhqV77bgg5oT5pVQdi5y
goloroden
goloroden approved these changes Sep 5, 2026
View reviewed changes

@goloroden goloroden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moves the tests onto Microsoft.Testing.Platform, which the .NET 10 SDK requires. All three QA jobs pass, including net8.0.

@goloroden
goloroden merged commit 6b32863 into main Sep 5, 2026
4 checks passed
@goloroden
goloroden deleted the dependabot/nuget/src/EventSourcingDb.Tests/xunit.v3-4.0.0 branch September 5, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goloroden goloroden goloroden approved these changes

Assignees

@goloroden goloroden

Labels

Dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@goloroden