automatically sign up opted in users to the GWF mailing list #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrchrisadams
reviewed
Dec 1, 2025
| came from a admin portal signup. | ||
| """ | ||
| configuration = Configuration() | ||
| configuration.api_key["api-key"] = settings.BREVO_API_KEY |
Member
There was a problem hiding this comment.
Tim, can you let me know what happens if there is no API key set here from the environment variables?
My assumption is that we end up with exponential back off as the dramatiq worker keeps trying to connect to Brevo, but I can't tell that's what happens.
We might want to raise an explicit exception like NoBrevoCredentials here, to make it explicit why this is failing, or run a check before we try to use the BREVO_* constants.
I think we might need to update the various places we have env vars set too (groan...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
....using the Brevo API.
Contacts are tagged with a "source" label to ensure that we can track that they arrived through the admin portal, and the call to the Brevo API is handled by a dramatiq worker, so that retries are automatically handled on error, and the main web process is not blocked on the API call.