add db_extra_options parameter #1195
Open
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaes
force-pushed
the
db_extra_options
branch
from
110a480 to
cbd76b2
Compare
dmaes
force-pushed
the
db_extra_options
branch
from
cbd76b2 to
98ed32c
Compare
ekohl
reviewed
Jan 13, 2025
| @@ -33,3 +34,6 @@ | |||
| password: <%= stdlib::to_ruby($password) %> | |||
| <% } -%> | |||
| pool: <%= $db_pool %> | |||
| <% $extra_options.each |String $k, String $v| { -%> | |||
| <%= $k %>: <%= $v %> | |||
There was a problem hiding this comment.
Should this also use stdlib::to_ruby to ensure things are quoted if needed? I don't trust unquoted strings with random input.
| @@ -33,3 +34,6 @@ | |||
| password: <%= stdlib::to_ruby($password) %> | |||
| <% } -%> | |||
| pool: <%= $db_pool %> | |||
| <% $extra_options.each |String $k, String $v| { -%> | |||
There was a problem hiding this comment.
I'd trust the header a the top to enforce the type and avoid duplication.
Suggested change
| <% $extra_options.each |String $k, String $v| { -%> | |
| <% $extra_options.each |$k, $v| { -%> |
| @@ -230,6 +233,7 @@ | |||
| Optional[String[1]] $db_sslmode = undef, | |||
| Optional[String[1]] $db_root_cert = undef, | |||
| Optional[Integer[0]] $db_pool = undef, | |||
| Hash[String, String] $db_extra_options = {}, | |||
There was a problem hiding this comment.
Are there options that are numbers? So something like this:
Suggested change
| Hash[String, String] $db_extra_options = {}, | |
| Hash[String, Variant[String, Integer]] $db_extra_options = {}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
db_extra_optionsparameter, to allow adding custom parameters in the database.yml config.Fixes #1194