Add Pulp plugins section#57
Conversation
ogajduse
force-pushed
the
add-pulp-plugins-section
branch
from
67d6d00 to
ee87dee
Compare
|
Great review comments, thank you, @ekohl. It's ready for re-review. |
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Some further suggestions to keep it short, but overall 👍
| satellite: true | ||
| tests: | ||
| github: | ||
| Python: ci.yml |
There was a problem hiding this comment.
This is part of the plugin template (https://github.com/pulp/plugin_template/blob/main/.github/workflows/ci.yml) so is this something that we should encode in PulpPlugin in fpo.py? I'm also fine keeping that out of scope and leaving it for the next plugin we add.
There was a problem hiding this comment.
Good suggestion. I'd say it still fits within the scope of this PR. Implemented.
I also raised #58 to consider whether we want to implement the same for the other classes.
| # Pulp plugins that integrate with Foreman ecosystem | ||
| # Packaged in pulpcore-packaging, not foreman-packaging | ||
| smart_proxy: | ||
| rpm: python-pulp-smart-proxy |
There was a problem hiding this comment.
I'd also suggest to implement a method to derive the package name from the plugin name in PulpPlugin, taking inspiration from:
foreman-plugin-overview/fpo.py
Lines 66 to 69 in 47b07e6
Then simplify this
| rpm: python-pulp-smart-proxy | |
| rpm: true |
ogajduse
force-pushed
the
add-pulp-plugins-section
branch
from
ee87dee to
b498066
Compare
Add dedicated section for Pulp plugins that integrate with Foreman
ecosystem. These are Python-based plugins packaged in pulpcore-packaging,
distinct from libraries and Smart Proxy modules.
Changes based on review feedback:
- Auto-derive RPM package name from plugin name (python-pulp-{name})
- Auto-generate default tests (ci.yml from pulp plugin_template)
- Remove unused rpm_directory and deb_directory fields
- Simplify rpm_url property to use pulpcore-packaging directly
- Always render Pulp Plugins section (no conditional checks)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ogajduse
force-pushed
the
add-pulp-plugins-section
branch
from
b498066 to
50a30e0
Compare
| # Packaged in pulpcore-packaging, not foreman-packaging | ||
| smart_proxy: | ||
| rpm: true | ||
| github_team: 'theforeman/pulp' |
There was a problem hiding this comment.
This is incorrect. Do we want to add pulp_smart_proxy to the "foremanctl" team?
There was a problem hiding this comment.
changed to theforeman/foremanctl
The pulp_smart_proxy plugin is now managed by the foremanctl team, as confirmed in the review discussion.
3 participants
Summary
Adds a dedicated
pulp_pluginssection to the Foreman plugin overview website for Pulp plugins that integrate with the Foreman ecosystem.Changes
PulpPlugindataclass with:pulp_{short_name}→pulp_smart_proxypython-pulp-{name}(with dashes)ci.ymlinstaller: falseby defaultpulp_pluginssection with first entry:smart_proxyFirst Plugin
python-pulp-smart-proxyin pulpcore-packagingRelated: Issue #58 proposes extending auto-generation to other plugin types
🤖 Generated with Claude Code