Add missing github_team and satellite attributes to config.yaml#52
Open
ogajduse wants to merge 5 commits into
Open
Add missing github_team and satellite attributes to config.yaml#52ogajduse wants to merge 5 commits into
ogajduse wants to merge 5 commits into
Conversation
ekohl
reviewed
Apr 10, 2026
| github_org: 'theforeman' | ||
| github_team: 'theforeman/ldap-fluff' | ||
| rpm: true | ||
| satellite: true |
Member
There was a problem hiding this comment.
I don't think we really track the satellite status of all the libraries. Pretty sure that it should be set to true for all of them now.
Member
Author
There was a problem hiding this comment.
Right, we don't track all of them. I figured out while working on this. :)
I set satellite: true for all of them.
| kafo_parsers: | ||
| deb: true | ||
| rpm: true | ||
| kafo_wizards: |
Member
There was a problem hiding this comment.
If you want to be complete, kafo* is owned by theforeman/installer
- Add github_team to 22 projects (smart proxy providers/modules, CLI plugins, client tools, libraries) - Add satellite: true to 28 projects verified against satellite-packaging - Remove incorrect satellite: true from foreman_hooks - Add foremanctl library entry with proper attributes These additions were identified by cross-referencing: - GitHub teams data from theforeman organization - satellite-packaging/package_manifest.yaml for Satellite-shipped packages - Existing patterns in config.yaml for team assignments Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ogajduse
changed the title
ianballou
reviewed
May 4, 2026
ianballou
left a comment
ianballou
left a comment
There was a problem hiding this comment.
The Katello bits in here look good!
ogajduse
commented
May 7, 2026
| rpm: true | ||
| translations: true | ||
| github_org: 'Katello' | ||
| github_team: 'Katello/katello' |
Member
Author
There was a problem hiding this comment.
This should be Katello/katello-core
adamruzicka
reviewed
May 7, 2026
Contributor
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
Two nitpicks, otherwise looks good
- Change katello plugin team from Katello/katello to Katello/katello-core - Change katello-host-tools team from Katello/katello to Katello/katello-core - Change smart_proxy dynflow provider team to theforeman/foreman-tasks - Add github_team to dynflow library (theforeman/foreman-tasks) These changes align with CODEOWNERS in foreman-packaging and correct team assignments based on review feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing metadata attributes to projects in config.yaml to improve completeness and accuracy.
Changes
Verification
Changes were verified by: