Update foreman package dependencies #5735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
commented
Aug 31, 2020
| @@ -263,7 +263,7 @@ BuildRequires: systemd | |||
| # start package.json devDependencies BuildRequires | |||
| BuildRequires: %{?scl_prefix}npm(@babel/core) >= 7.7.0 | |||
| BuildRequires: %{?scl_prefix}npm(@babel/core) < 8.0.0 | |||
| BuildRequires: %{?scl_prefix}npm(@theforeman/builder) >= 4.11.1 | |||
| BuildRequires: %{?scl_prefix}npm(@theforeman/builder) >= 4.12.0 | |||
There was a problem hiding this comment.
theforeman/foreman#7896 bumps it to 4.14 so I'm going to update this ahead of time.
There was a problem hiding this comment.
Could you revert it back to 4.12.0 to reflect current state? This is mixing two update concerns that will block builds unless we know that the referenced PR is going in really soon.
There was a problem hiding this comment.
This doesn't block the build since 4.14.0 is available (#5687). Repoclosure is only complaining about sd_notify which is because we didn't mash.
ekohl
force-pushed
the
rpm/update-foreman-deps
branch
from
0c246f7 to
c2dbf9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.