-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Touch methods #135
feat: Touch methods #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and sorry this felt under the radar. I'm suggesting a couple small changes and then will approve and merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The request definitions are not fully correct according to spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more API & serialization changes are needed to complete this!
@Squidonomics , do you have time to look into the last tweaks on this PR? I would love to merge it. |
@tristanlabelle Sorry about that been locked in on a side project , yeah I'll be home in about 45 minutes and I'll tweak it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contribution and iterating :). Looking great!
Implements methods:
/session/{sessionId}/touch/doubleclick
/session/{sessionId}/touch/flick