Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Touch methods #135

Merged
merged 7 commits into from
Mar 27, 2024

Conversation

Squidonomics
Copy link
Contributor

Implements methods:
/session/{sessionId}/touch/doubleclick
/session/{sessionId}/touch/flick

Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry this felt under the radar. I'm suggesting a couple small changes and then will approve and merge this.

Sources/WebDriver/Session.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Element.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Element.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Element.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Requests.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request definitions are not fully correct according to spec.

Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more API & serialization changes are needed to complete this!

Sources/WebDriver/Requests.swift Show resolved Hide resolved
Sources/WebDriver/Requests.swift Show resolved Hide resolved
Sources/WebDriver/Element.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Element.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Element.swift Show resolved Hide resolved
Docs/SupportedAPIs.md Outdated Show resolved Hide resolved
@tristanlabelle
Copy link
Contributor

@Squidonomics , do you have time to look into the last tweaks on this PR? I would love to merge it.

@Squidonomics
Copy link
Contributor Author

@Squidonomics , do you have time to look into the last tweaks on this PR? I would love to merge it.

@tristanlabelle Sorry about that been locked in on a side project , yeah I'll be home in about 45 minutes and I'll tweak it

Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution and iterating :). Looking great!

@tristanlabelle tristanlabelle merged commit c07d968 into thebrowsercompany:main Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants