Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Location method #132

Merged
merged 7 commits into from
Mar 7, 2024
Merged

feat: Location method #132

merged 7 commits into from
Mar 7, 2024

Conversation

Squidonomics
Copy link
Contributor

Implements the following method:
/session/:sessionId/location

tristanlabelle
tristanlabelle requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Coordinates should use floating-point values and we can improve the API shape a little.

Sources/WebDriver/Requests.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Requests.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Requests.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Session.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Session.swift Outdated Show resolved Hide resolved
tristanlabelle
tristanlabelle requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. There's a couple things that still need tweaking to take advantage of the Location type.

Docs/SupportedAPIs.md Outdated Show resolved Hide resolved
Sources/WebDriver/Location.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Location.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Location.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Requests.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Session.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Session.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Session.swift Outdated Show resolved Hide resolved
tristanlabelle
tristanlabelle reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't have (latitude, longitude, altitude) and location redundantly. This PR will also need rebasing.

Sources/WebDriver/Requests.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Session.swift Outdated Show resolved Hide resolved
tristanlabelle
tristanlabelle approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tristanlabelle tristanlabelle merged commit 141d9ec into thebrowsercompany:main Mar 7, 2024
1 check passed
@Squidonomics Squidonomics deleted the squid/geolocation branch March 7, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanlabelle tristanlabelle tristanlabelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Squidonomics @tristanlabelle