Remove the default retry timeout. #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffdav What do you think of this? (and updating the arc UI tests to set the value) |
|
Seems reasonable to me. Should we set it in a test? And didn't we have a constant somewhere, or did that already go away? |
jeffdav
approved these changes
Sep 18, 2023
|
Here was the constant: |
|
Implemented in #153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webdriver-swiftshould not dictate what is the correct default retry timeout for every testing application. The burden of choosing that magic number should be higher level. This is similar to how the implicit wait timeout in webdriver defaults to zero.