Skip to content

Support for capturing MPEG-TS with Linux DVB #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darkjames
Copy link

Initial support for capturing MPEG-TS with Linux DVB API.
it capture all PIDs and you must manually tune before capturing.

Code based on dvbtraffic util from dvb-apps under public domain
@darkjames
Copy link
Author

Failed — The Travis CI build failed (Details)

Most likely because Travis haven't done autoreconf, and I didn't submit generated (configure, config.h.in) files.

@mcr
Copy link
Member

mcr commented Feb 15, 2015

This looks fun. It looks like it requires some dvb libraries to be loaded; can you add those to travis.yml?
Can you rebase? If you include the configure, please do so as separate patch, as I will regenerate on reference machine.

@guyharris
Copy link
Member

It looks like it requires some dvb libraries to be loaded

I'm not seeing any special DVB library calls - are you sure they're there?

Can you rebase?

Yes, please rebase this.

@guyharris
Copy link
Member

Most likely because Travis haven't done autoreconf, and I didn't submit generated (configure, config.h.in) files.

Please submit them, even though they're generated files.

# __KERNEL_STRICT_NAMES getting defined by some other include.
#
# Check whether the includes Just Work. If not, don't turn on
# netfilter support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably you mean "DVB", not "netfilter".

# Check whether the includes Just Work. If not, don't turn on
# netfilter support.
#
AC_MSG_CHECKING(whether we can compile the netfilter support)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here as well.

@guyharris
Copy link
Member

I also noted some places in configure.in (which is now called configure.ac) where it says "netfilter" but means "DVB" (copy-and-pasteo).

@mcr
Copy link
Member

mcr commented Apr 19, 2019

This code is still welcome, if you'd like to rebase.

@infrastation
Copy link
Member

This is the longest standing pull request in this project. @darkjames, if you would like to revive this contribution, please comment within 7 days. Otherwise it will be closed.

@guyharris
Copy link
Member

@darkjames I turned the change into a patch, applied it to the tip of the main branch, fixed the two cases of "netfilter" instead of "DVB" in comments, brought it up to date with changes made to libpcap since 2013, and added CMake support. It appears to compile; I have no DVB hardware with which to test it (nor a physical Linux box into which to plug that hardware, and I live in ATSCland anyway, so I'm not sure I could capture any traffic with a physical Linux box with DVB hardware).

Is this still of interest? I'll ask on tcpdump-workers, wireshark-users, and wireshark-dev as well.

@infrastation
Copy link
Member

I have a USB device that has some DVB receiving capability, but not the aerial; also it is not clear whether the device can receive the terrestrial DVB that is said to be available around here, and whether it is what the proposed change implements. This patch would be much easier to test if there was someone with a working Linux DVB setup who could try the patch and tell how it works.

@infrastation
Copy link
Member

I asked around on IRC, but have not found a volunteer equipped with the right props. If you were going to ask on the mailing lists, please do.

@infrastation
Copy link
Member

Current status: I managed to find a way to test the patch with DVB-T signal, Guy has the test results.

@infrastation
Copy link
Member

Whilst this remains a work in progress, let's give credit where credit is due. Testing of the proposed patch (rebased by Guy Harris) happened thanks to various help provided by Stewart Williamson, a fine Scotsman and a cyclist, a former racer of the Musselburgh Roads Cycling Club.

@infrastation
Copy link
Member

The current work in progress rebased on the current master branch (after the recent DPDK changes) is in the "GHPR330-DVB" branch in the "libpcap-incomplete-works" repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants