rpcap: add timeout configuration on socket connect#1091
rpcap: add timeout configuration on socket connect#1091GabrielGanne wants to merge 2 commits intothe-tcpdump-group:masterfrom
Conversation
GabrielGanne
force-pushed
the
rpcap
branch
2 times, most recently
from
e952adb to
94d6ed2
Compare
GabrielGanne
force-pushed
the
rpcap
branch
3 times, most recently
from
38f59f7 to
7255939
Compare
|
Thank you for preparing these changes and addressing the CI feedback. Please do not include the regenerated |
Signed-off-by: Kevin Boulain <kevin.boulain@securactive.net> Signed-off-by: Gabriel Ganne <gganne@accedian.com>
Done. Sorry, I forgot to clean them out of the PR. |
|
The second commit ("rpcap: set keepalives on rpcap's control socket") is almost an exact copy of the changes from pull request #773, which still requires significant work to become good for merging (see the detailed comments there). |
Allow to set a custom timeout to the connect to avoid waiting minutes for nothing should the connect() call fail. Signed-off-by: Kevin Boulain <kevin.boulain@securactive.net> Signed-off-by: Gabriel Ganne <gganne@accedian.com>
|
Hi @infrastation I'm willing to take over #773 and do the requested changes. |
|
@GabrielGanne, please go ahead with your version of the TCP keepalive patch. |
|
Does this work for rpcap-over-TLS connections? |
3 participants
Hi,
This is a small proposal to allow to configure the connection timeout for rpcap sockets.
This is just to avoid waiting minutes for nothing should the connect() call fail.
Best regards,