feat: dark/light mode #419
Conversation
There was a problem hiding this comment.
https://deploy-preview-419--tph.netlify.app/resources/ it doesn't seem like the theme is changing consistently after refreshing and clicking change theme.
Could you also remove the package-lock changes? We will probably migrate over to yarn eventually
|
Not sure what to do about the eslint error. I guess everything else should be fixed now. |
src/hooks/useMedia.tsx
Outdated
| useEffect(() => { | ||
| if (typeof window === "undefined") return | ||
|
|
||
| const mediaQueries = queries.map((query) => window.matchMedia(query)) |
There was a problem hiding this comment.
I think it can be fixed the same way other hook does it:
const windowGlobal = typeof window !== "undefined" && window
There was a problem hiding this comment.
Aaaah. Good Idea.
|
Not sure what is happening, tried a couple more ways, still shows the same error. |
veksen
force-pushed
the
feat/system-theme-preference
branch
from
ec8bb07 to
ee9b3c5
Compare
|
✔️ Deploy Preview for tph ready! 🔨 Explore the source changes: e87dd88 🔍 Inspect the deploy log: https://app.netlify.com/sites/tph/deploys/616f1281069699000794b881 😎 Browse the preview: https://deploy-preview-419--tph.netlify.app |
+ read media query for theme preference + improved typing of useLocalStorage hook
fix: lint errors fix: lint error fix: lint error
veksen
force-pushed
the
feat/system-theme-preference
branch
from
ee9b3c5 to
e87dd88
Compare
|
Everything seems to work fine for me, and seems to resolve the issue
Did you find issues with the current preview? |
Should close #360 and hopefully #334