fix: accept individual parameters in FHIR tool functions (Fixes #29, #56) - #57
Open
rtmalikian wants to merge 1 commit into
Open
Conversation
All 8 FHIR resource tools accepted a single FhirQueryRequest Pydantic model, but MCP agents send individual parameters. This caused Pydantic validation errors when agents tried to call the tools. Changed all tools to accept individual parameters (method, path, body) and construct the FhirQueryRequest model internally. This matches the pattern used by get_loinc_codes and is what MCP agents expect. Fixes the-momentum#29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56
Problem
All 8 FHIR resource tools (
request_patient_resource,request_observation_resource, etc.) accept a singleFhirQueryRequestPydantic model parameter, but MCP agents (like mcp-use) send individual parameters. This causes Pydantic validation errors:{}forrequest(empty dict) → validation fails becausemethodandpathare required fields'GET'forrequest(a string) → validation fails because Pydantic expects a dict or model instanceThe
get_loinc_codestool already works correctly because it accepts individual parameters — this fix applies the same pattern to all FHIR resource tools.Solution
Changed all 8 FHIR resource tools to accept individual parameters (
method: Literal[...],path: str,body: dict | None) instead of a singleFhirQueryRequestmodel. The model is constructed internally from the individual parameters. This:get_loinc_codesFhirQueryRequestmodelVerification
All modified files pass Python syntax checks:
Affected Files
app/mcp/v1/tools/patient.pyapp/mcp/v1/tools/observation.pyapp/mcp/v1/tools/generic.pyapp/mcp/v1/tools/encounter.pyapp/mcp/v1/tools/condition.pyapp/mcp/v1/tools/allergy_intolerance.pyapp/mcp/v1/tools/immunization.pyapp/mcp/v1/tools/medication.pyapp/mcp/v1/tools/family_member_history.pyapp/mcp/v1/tools/document_reference.pyAbout the Author: Raphael Malikian — Clinical AI Solutions Architect. I specialise in building and fixing AI/ML systems for healthcare, including vector databases, RAG pipelines, and clinical NLP. If you need help with your project or think I can add value to your organisation, feel free to reach out — I'd love to connect.
📧 rtmalikian@gmail.com
🔗 GitHub: https://github.com/rtmalikian
🔗 LinkedIn: http://www.linkedin.com/in/raphael-t-malikian-mbbs-bsc-hons-71075436a
Disclosure: This code was developed with assistance from mimo-2.5-pro (Xiaomi) via Hermes Agent (Nous Research). All changes were reviewed, tested against the actual codebase, and verified for correctness.