Skip to content

Conversation

@Gnuxie
Copy link
Member

@Gnuxie Gnuxie commented May 13, 2025

  1. Add a boolean presentation type and translator
  2. Allow the text command reader to read negative integers
  3. Add simple quoted strings which are unbalanced quote resistant.
  • Remember to add the BooleanPresnetationTypeTranslator to draupnir.

@Gnuxie Gnuxie marked this pull request as ready for review May 13, 2025 22:48
@Gnuxie
Copy link
Member Author

Gnuxie commented May 13, 2025

The type parameters on super cool stream savingPositionIf are broken and also predicate is a rubbish name but whatever. Should be called discardIf or whatever

stream.readChar();
return word.join("");
} else {
return undefined;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't error here because we haven't figured the infrastructure for reader errors that are really readable to the user and i don't want them to see an error and assume something is broken and i think that this gives them mroe chance of finding out that they wrote something silly. But yes long term we need the infrastructure for read errors.

@Gnuxie Gnuxie force-pushed the gnuxie/more-presentation-types branch from ad8510c to d271966 Compare May 14, 2025 22:33
@Gnuxie Gnuxie merged commit 3572c72 into main May 14, 2025
3 checks passed
@Gnuxie Gnuxie deleted the gnuxie/more-presentation-types branch May 14, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants