Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item section updated-delete and shopping cart icons added #52

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

didemydn
Copy link
Collaborator

@didemydn didemydn commented Oct 4, 2024

Description

I have completed the styling of list items in the list view. (ListItem.jsx)

Related Issue

closes #51

Acceptance Criteria

  • The list items must adhere to the specified color palette.
  • A shopping cart icon should be added to the list view
  • The urgency categories must be styled to enhance visibility.
  • A delete icon should be included for each list item.

Updates

Before

image

After

image

Copy link

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit 6a4c027):

https://tcl-78-smart-shopping-list--pr52-dc-listpage-css-8c5y3t3k.web.app

(expires Fri, 11 Oct 2024 20:26:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c781903507c1507075d7a974036959ddeec29c0a

@didemydn didemydn requested review from Amaka202 and vivitt October 4, 2024 20:27
@@ -1,5 +1,7 @@
import { useState, useEffect } from 'react';
import './ListItem.css';
import { FaTrashCan } from 'react-icons/fa6';
import { FaCartShopping } from 'react-icons/fa6';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can move both icon imports into one line since they are imported from the same collection

Copy link
Collaborator

@eva-lng eva-lng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout of the listed items works well and looks good. Since we haven't decided on colors yet I won't comment on them. A small suggestion, it might look nicer if the urgency labels are in uppercase :)

Copy link
Collaborator

@Amaka202 Amaka202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done Didem

@didemydn didemydn merged commit 1acfd64 into main Oct 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling list item on list view
3 participants