Skip to content

FRR: Handle empty results and missing attributes properly #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

FRR: Handle empty results and missing attributes properly #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
934e8f3
bgp_route_frr: skip empty route query results
sinuscosinustan Oct 4, 2025
3287393
frr: set default values for optional next-hop fields
sinuscosinustan Oct 4, 2025
79d235c
frr: return AS0 if AS_PATH length is zero
sinuscosinustan Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions hyperglass/models/parsing/frr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ class FRRNextHop(_FRRBase):

ip: str
afi: str
metric: int
metric: int = 0
accessible: bool
used: bool
used: bool = False


class FRRPeer(_FRRBase):
Expand Down Expand Up @@ -65,7 +65,15 @@ class FRRPath(_FRRBase):
def validate_path(cls, values):
"""Extract meaningful data from FRR response."""
new = values.copy()
new["aspath"] = values["aspath"]["segments"][0]["list"]
# Local prefixes (i.e. those in the same ASN) usually have
# no AS_PATH.
# Set AS_PATH to AS0 for now as we cannot ensure that the
# ASN for the prefix is the primary ASN.
if values["aspath"]["length"] != 0:
new["aspath"] = values["aspath"]["segments"][0]["list"]
else:
# TODO: Get an ASN that is reasonable (e.g. primary ASN)
new["aspath"] = [0]
community = values.get("community", {"list": []})
new["community"] = community["list"]
new["lastUpdate"] = values["lastUpdate"]["epoch"]
Expand Down
4 changes: 4 additions & 0 deletions hyperglass/plugins/_builtin/bgp_route_frr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ def parse_frr(output: t.Sequence[str]) -> "OutputDataModel":

_log.debug("Pre-parsed data", data=parsed)

# If empty (i.e. no route found), skip
if not parsed:
continue

validated = FRRBGPTable(**parsed)
bgp_table = validated.bgp_table()

Expand Down