Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable parallel for TestEndpointSetUpdate_StrictEndpointMetadata #8022

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 25, 2024

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Running this test in parallel with other tests seem caused a data race. #7353 (comment)

==================
WARNING: DATA RACE
Write at 0x000002eddc60 by goroutine 33:
  github.com/thanos-io/thanos/pkg/query.TestEndpointSetUpdate_StrictEndpointMetadata()
      /home/runner/work/thanos/thanos/pkg/query/endpointset_test.go:470 +0x8a
  testing.tRunner()
      /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1690 +0x226
  testing.(*T).Run.gowrap1()
      /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1743 +0x44

Previous read at 0x000002eddc60 by goroutine 5016:
  github.com/thanos-io/thanos/pkg/info/infopb.(*StoreInfo).Size()
      /home/runner/work/thanos/thanos/pkg/info/infopb/rpc.pb.go:968 +0x4d
  github.com/thanos-io/thanos/pkg/info/infopb.(*InfoResponse).Size()
      /home/runner/work/thanos/thanos/pkg/info/infopb/rpc.pb.go:936 +0x138
  github.com/thanos-io/thanos/pkg/info/infopb.(*InfoResponse).Marshal()
      /home/runner/work/thanos/thanos/pkg/info/infopb/rpc.pb.go:549 +0x2e
  google.golang.org/protobuf/internal/impl.legacyMarshal()
      /home/runner/go/pkg/mod/google.golang.org/[email protected]/internal/impl/legacy_message.go:411 +0xf9
  google.golang.org/protobuf/proto.MarshalOptions.marshal()
      /home/runner/go/pkg/mod/google.golang.org/[email protected]/proto/encode.go:194 +0x504
  google.golang.org/protobuf/proto.Marshal()
      /home/runner/go/pkg/mod/google.golang.org/[email protected]/proto/encode.go:110 +0x52
  google.golang.org/grpc/encoding/proto.codec.Marshal()
      /home/runner/go/pkg/mod/google.golang.org/[email protected]/encoding/proto/proto.go:47 +0x55
  google.golang.org/grpc/encoding/proto.(*codec).Marshal()
      <autogenerated>:1 +0x53
  google.golang.org/grpc.encode()
      /home/runner/go/pkg/mod/google.golang.org/[email protected]/rpc_util.go:647 +0x6a
  google.golang.org/grpc.(*Server).sendResponse()
      /home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:1130 +0xc5
  google.golang.org/grpc.(*Server).processUnaryRPC()
      /home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:1416 +0x2092
  google.golang.org/grpc.(*Server).handleStream()
      /home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:1780 +0x1824
  google.golang.org/grpc.(*Server).serveStreams.func2.1()
      /home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:1019 +0x158

Verification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant